Skip to content

Fixed AttributeError: 'str' object has no attribute#8463

Merged
Nusnus merged 4 commits intocelery:mainfrom
Katz-Consulting-Group:blm-282
Aug 30, 2023
Merged

Fixed AttributeError: 'str' object has no attribute#8463
Nusnus merged 4 commits intocelery:mainfrom
Katz-Consulting-Group:blm-282

Conversation

@Nusnus
Copy link
Copy Markdown
Member

@Nusnus Nusnus commented Aug 30, 2023

Fixes #8456

Also fixes similar issue in other places.

@Nusnus Nusnus added this to the 5.3.x milestone Aug 30, 2023
@Nusnus Nusnus requested a review from thedrow August 30, 2023 12:51
@Nusnus Nusnus self-assigned this Aug 30, 2023
@Nusnus Nusnus marked this pull request as ready for review August 30, 2023 14:47
@Nusnus
Copy link
Copy Markdown
Member Author

Nusnus commented Aug 30, 2023

Tox is failing again, everything passes. This PR will wait until I'll fix the tox issue for now.

Nusnus added 4 commits August 30, 2023 18:56
… keys.

Prevents error like:
AttributeError: 'str' object has no attribute 'link_error'
…eys.

Prevents error like:
AttributeError: 'str' object has no attribute '_app'
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (af1d7a1) 87.42% compared to head (ebf0a8e) 87.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8463   +/-   ##
=======================================
  Coverage   87.42%   87.42%           
=======================================
  Files         148      148           
  Lines       18488    18488           
  Branches     3155     3155           
=======================================
  Hits        16164    16164           
  Misses       2034     2034           
  Partials      290      290           
Flag Coverage Δ
unittests 87.39% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
celery/canvas.py 97.44% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError thrown when using link_error/on_error on a rewritten chain when task_allow_error_cb_on_chord_header is enabled

2 participants