Skip to content

setup.py: enable include_package_data#8379

Merged
auvipy merged 1 commit intocelery:mainfrom
elohmeier:include-package-data
Jul 19, 2023
Merged

setup.py: enable include_package_data#8379
auvipy merged 1 commit intocelery:mainfrom
elohmeier:include-package-data

Conversation

@elohmeier
Copy link
Copy Markdown
Contributor

@elohmeier elohmeier commented Jul 18, 2023

Note: Before submitting this pull request, please review our contributing
guidelines.

Description

I think #8248 introduced a issue with celery cli complaining about missing png assets:

[2023-07-18 12:19:28,552] [CRITICAL] [celery.worker] Unrecoverable error: FileNotFoundError(2, 'No such file or directory')
Traceback (most recent call last):
  File "/nix/store/fidxvxfcmr6g69c066097ldfcjxyr92f-python3.10-celery-5.3.0/lib/python3.10/site-packages/celery/worker/worker.py", line 202, in start
    self.blueprint.start(self)
  File "/nix/store/fidxvxfcmr6g69c066097ldfcjxyr92f-python3.10-celery-5.3.0/lib/python3.10/site-packages/celery/bootsteps.py", line 112, in start
    self.on_start()
  File "/nix/store/fidxvxfcmr6g69c066097ldfcjxyr92f-python3.10-celery-5.3.0/lib/python3.10/site-packages/celery/apps/worker.py", line 135, in on_start
    self.emit_banner()
  File "/nix/store/fidxvxfcmr6g69c066097ldfcjxyr92f-python3.10-celery-5.3.0/lib/python3.10/site-packages/celery/apps/worker.py", line 166, in emit_banner
    print(term.imgcat(static.logo()))
  File "/nix/store/fidxvxfcmr6g69c066097ldfcjxyr92f-python3.10-celery-5.3.0/lib/python3.10/site-packages/celery/utils/term.py", line 177, in imgcat
    _read_as_base64(path), _IMG_POST)
  File "/nix/store/fidxvxfcmr6g69c066097ldfcjxyr92f-python3.10-celery-5.3.0/lib/python3.10/site-packages/celery/utils/term.py", line 169, in _read_as_base64
    with codecs.open(path, mode='rb') as fh:
  File "/nix/store/79mn78vhybpkklj9vmgfrm5vk98jyg9q-python3-3.10.12/lib/python3.10/codecs.py", line 906, in open
    file = builtins.open(filename, mode, buffering)
FileNotFoundError: [Errno 2] No such file or directory: '/nix/store/fidxvxfcmr6g69c066097ldfcjxyr92f-python3.10-celery-5.3.0/lib/python3.10/site-packages/celery/utils/static/celery_128.png'

The MANIFEST.in is referencing that png file. This change re-enables including data files when packaging, fixing that error.

@elohmeier elohmeier mentioned this pull request Jul 18, 2023
Closed
12 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 18, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (ccc02b7) 87.07% compared to head (f8add5c) 87.07%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8379   +/-   ##
=======================================
  Coverage   87.07%   87.07%           
=======================================
  Files         148      148           
  Lines       18491    18491           
  Branches     3152     3152           
=======================================
  Hits        16101    16101           
  Misses       2110     2110           
  Partials      280      280
Flag Coverage Δ
unittests 87.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@auvipy auvipy merged commit 78ab64e into celery:main Jul 19, 2023
@auvipy auvipy added this to the 5.3.x milestone Jul 19, 2023
@auvipy
Copy link
Copy Markdown
Member

auvipy commented Jul 19, 2023

thanks for fixing it!

@elohmeier elohmeier deleted the include-package-data branch July 19, 2023 05:51
@asmeurer
Copy link
Copy Markdown

asmeurer commented Aug 30, 2023

If anyone runs into this issue No such file or directory: '.../lib/python3.10/site-packages/celery/utils/static/celery_128.png' using celery in iTerm2, you can work around it by setting ITERM_PROFILE='' before running the celery worker.

@asmeurer asmeurer mentioned this pull request Aug 30, 2023
Closed
@auvipy
Copy link
Copy Markdown
Member

auvipy commented Aug 31, 2023

so we need a quik bug fix release soon, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@auvipy auvipy auvipy approved these changes

Assignees

No one assigned

Labels

PR Type: Bugfix

Projects

None yet

Milestone

5.3.x

Development

Successfully merging this pull request may close these issues.

3 participants

@elohmeier @auvipy @asmeurer