Merged
Conversation
77f86af to
022d346
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #8248 +/- ##
==========================================
+ Coverage 85.08% 87.09% +2.00%
==========================================
Files 148 148
Lines 18455 18467 +12
Branches 2428 2524 +96
==========================================
+ Hits 15703 16083 +380
+ Misses 2475 2106 -369
- Partials 277 278 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
auvipy
approved these changes
May 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
Cleaning before #8238.
This PR:
zip_safeparameter as this is considered deprecated and used for egg distribution format, cf. https://setuptools.pypa.io/en/latest/deprecated/zip_safe.html.cmdclassas it seems unused, cf. https://setuptools.pypa.io/en/latest/userguide/extension.html for more context.include_package_dataparameter as this is not used, cf. https://setuptools.pypa.io/en/latest/userguide/datafiles.html.