You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a proposal about switching from scattered build and requirements files to PEP-517 build system using poetry and poetry-core with pyproject.toml.
The work is not done yet, I'd like to get some feedback about the idea first before moving forward.
TODO
Check that we have no regression in wheel content
Check that dependencies version and extras are the same as before
Hey @stegayet , thank you for taking the lead on such proposal.
I had on my mind upgrading us to Poetry after 5.3 release, as the upcoming pytest-celery also uses poetry and I think it would benefit Celery as well.
That being said, it means that it will be interesting after the release which unfortunately is still delaying.
Also, I believe a proper upgrade should be on more repos and not just Celery.
What about keeping setuptools and just migrating to pyproject? Poetry can be tricky w.r.t. dependencies for libraries (see this article) and things might change with python-poetry/poetry#9135, meaning more work will have to be done once PEP 621 gets supported by Poetry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
WIP
This is a proposal about switching from scattered build and requirements files to PEP-517 build system using
poetryandpoetry-corewithpyproject.toml.The work is not done yet, I'd like to get some feedback about the idea first before moving forward.
TODO