Update shellwords to v1.0.1, relax Go version directive#3464
Merged
Conversation
d016214 to
63967b0
Compare
DrJosh9000
reviewed
Sep 9, 2025
63967b0 to
aede20a
Compare
Co-Authored-By: Hayden <8418760+haydentherapper@users.noreply.github.com>
aede20a to
d8a5e07
Compare
Contributor
Author
|
@DrJosh9000 i've bumped the |
DrJosh9000
reviewed
Sep 11, 2025
| go 1.24.3 | ||
| go 1.24.0 | ||
|
|
||
| toolchain go1.24.5 |
Contributor
There was a problem hiding this comment.
It says 1.24.5, and if I'm understanding the issue correctly, we may not want to specify a toolchain line at all?
Contributor
There was a problem hiding this comment.
We looked at the docs again and this is probably fine 👍
DrJosh9000
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We previously relied on a dependency,
shellwords, that required that the Agent to be on a very specific version of Go (1.24.3). In Shellwords v1.0.1, we relaxed this requirement to 1.24, so we should continue up the stream and make the agent as a go module a little more usableThis PR also adds a
toolchaindirective to thego.mod, which will do the work of actually selecting a go version to run commands likego testetc, where that heavy lifting was previously done by an overly-zealousgodirective.This work is pretty much taken wholesale from @haydentherapper's #3449, but with a couple tweaks.
Context
#3449
buildkite/shellwords#5
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)Disclosures / Credits
Thanks to @haydentherapper and @vpnachev for pushing this!
closes #3449