Relax Go version directive#3449
Closed
Hayden-IO wants to merge 2 commits into
Closed
Conversation
Without this change, dependents must specify the same Go version or newer in their go.mod file. The go version directive only needs to be the lowest version that provides the language features needed, which would be 1.x.0, with dependents building their packages using the latest toolchain. With the updated buildkite/shellwords, we can relax the go version directive to the minor version rather than a specific patch version. Signed-off-by: Hayden <8418760+haydentherapper@users.noreply.github.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Without this change, dependents must specify the same Go version or newer in their go.mod file. The go version directive only needs to be the lowest version that provides the language features needed, which would be 1.x.0, with dependents building their packages using the latest toolchain.
With the updated buildkite/shellwords, we can relax the go version directive to the minor version rather than a specific patch version.
Context
buildkite/shellwords#3 and buildkite/shellwords#5
Changes
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)Disclosures / Credits