Skip to content

Fix basic auth in buf curl#2096

Merged
jhump merged 1 commit intobufbuild:mainfrom
mattrobenolt:fix-basicauth
May 17, 2023
Merged

Fix basic auth in buf curl#2096
jhump merged 1 commit intobufbuild:mainfrom
mattrobenolt:fix-basicauth

Conversation

@mattrobenolt
Copy link
Contributor

basic auth needs the Basic prefix

Refs #2010

basic auth needs the Basic prefix
@CLAassistant
Copy link

CLAassistant commented May 17, 2023

CLA assistant check
All committers have signed the CLA.

@bufdev
Copy link
Member

bufdev commented May 17, 2023

Could you add a quick line to the changelog in the form "Fix ...", similar to other fix lines?

@bufdev bufdev changed the title curl: fix basic auth Fix basic auth in buf curl May 17, 2023
@jhump jhump merged commit b25d04c into bufbuild:main May 17, 2023
@jhump
Copy link
Member

jhump commented May 17, 2023

Sorry, @bufdev, I was in such a rush to get this fix in for my embarrassing mistake, I didn't see your request above. I took care of it in a separate PR here: #2097.

@mattrobenolt mattrobenolt deleted the fix-basicauth branch May 17, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants