Add support to "buf curl" for --user and --netrc credentials flags#2010
Add support to "buf curl" for --user and --netrc credentials flags#2010
Conversation
|
Thanks for doing this |
bufdev
left a comment
There was a problem hiding this comment.
Mostly nits, sorry for the double review
…tants for short flag names
|
@bufdev, FYI, I just pushed a commit to add a blurb about this change to the changelog. |
|
I just realized this doesn't work as expected. It tags the Right now, if I do: I end up with a request such as: And the expectation is this would be: Otherwise, the auth is invalid. Edit: It seems based on my very limited understanding and my basic testing of a |
|
PR to fix: #2096 Feel free to implement this however, but this gets it working. :) |
|
@mattrobenolt 🤦 , not sure how I missed this. I thought I had tried this out with real credentials to a BSR to verify, but maybe I imagined that. I know I did quite a lot of |
|
haha @jhump, no worries. Happens to us all. 🫶 |
This adds support for
-u/--user,-n/--netrc, and--netrc-fileflags tobuf curl. These flags work the same way in this context as the flags of the same name incurl.Resolves #1997.