fix: Capture let when the for body is not a block#16368
Merged
nicolo-ribaudo merged 2 commits intobabel:mainfrom Mar 20, 2024
Merged
fix: Capture let when the for body is not a block#16368nicolo-ribaudo merged 2 commits intobabel:mainfrom
let when the for body is not a block#16368nicolo-ribaudo merged 2 commits intobabel:mainfrom
Conversation
Member
liuxingbaoyu
commented
Mar 20, 2024
| Q | A |
|---|---|
| Fixed Issues? | Fixes #16367 |
| Patch: Bug Fix? | √ |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | √ |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
let when for does not follow a blocklet when for does not follow a block
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56562 |
nicolo-ribaudo
approved these changes
Mar 20, 2024
let when for does not follow a blocklet when the for body is not a block
JLHwung
approved these changes
Mar 20, 2024
Contributor
JLHwung
left a comment
There was a problem hiding this comment.
Can you add an exec.js test?
This was referenced May 18, 2024
This was referenced May 20, 2024
This was referenced Jun 18, 2024
Open
This was referenced Jun 19, 2024
This was referenced Jun 20, 2024
Open
This was referenced Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.