Skip to content

[Bug]: local let variable is not captured in for..in loop #16367

@ele828

Description

@ele828

💻

  • Would you like to work on a fix?

How are you using Babel?

babel-loader (webpack)

Input code

function proxyObserver(component) {
  for (let key in component.properties)
    if (component.properties[key].observer) {
      let base = component.properties[key].observer;
      component.properties[key].observer = () => {
        // console.log("key", key);
        base.apply(this);
      };
    }

  return component;
}

Configuration file name

No response

Configuration

No response

Current and expected behavior

local variable base is not captured into closure. note that when variable key is used in closure, it'll work as expected.

current behavior

function proxyObserver(component) {
  var _this = this;
  for (var key in component.properties) if (component.properties[key].observer) {
    var base = component.properties[key].observer;
    component.properties[key].observer = function () {
      // console.log("key", key);
      base.apply(_this);
    };
  }
  return component;
}

expected behavior

function proxyObserver(component) {
  var _this = this;
  var _loop = function _loop(key) {
    if (component.properties[key].observer) {
      var base = component.properties[key].observer;
      component.properties[key].observer = function () {
        // console.log("key", key);
        base.apply(_this);
      };
    }
  };
  for (var key in component.properties) {
    _loop(key);
  }
  return component;
}

Environment

babel playground

Possible solution

seem like only for in is not working

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    outdatedA closed issue/PR that is archived due to age. Recommended to make a new issue

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions