Skip to content

fix(eks-v2-alpha): ensure kubectl provider and handler functions use the same vpc configuration #36735

Merged
mergify[bot] merged 7 commits intomainfrom
eks-alpha-kubectl-vpc
Feb 5, 2026
Merged

fix(eks-v2-alpha): ensure kubectl provider and handler functions use the same vpc configuration #36735
mergify[bot] merged 7 commits intomainfrom
eks-alpha-kubectl-vpc

Conversation

@Abogical
Copy link
Member

@Abogical Abogical commented Jan 19, 2026 •
edited
Loading

Note: copied from #34878 with updated snapshots, credits to @msessa.

Issue # (if applicable)

Closes #34877

Reason for this change

The kubectl Provider function VpcConfig should match the Handler function.

Description of changes

  • Ensured the same vpc construct is passed to both Handler and Provider

Description of how you validated changes

  • Fixed the tests which were hiding the problem

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 labels Jan 19, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team January 19, 2026 23:09
@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Jan 19, 2026
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 19, 2026
@Abogical Abogical added the pr/needs-integration-tests-deployment Requires the PR to deploy the integration test snapshots. label Jan 19, 2026
@Abogical Abogical had a problem deploying to deployment-integ-test January 19, 2026 23:10 — with GitHub Actions Error
aws-cdk-automation
aws-cdk-automation previously requested changes Jan 19, 2026
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026 •
edited
Loading

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.

TestsPassed ✅SkippedFailed
Security Guardian Results48 ran48 passed
TestResult
No test annotations available

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026 •
edited
Loading

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.

TestsPassed ☑️SkippedFailed ❌️
Security Guardian Results with resolved templates48 ran47 passed1 failed
TestResult
Security Guardian Results with resolved templates
packages/@aws-cdk/aws-eks-v2-alpha/test/integ.eks-cluster.js.snapshot/aws-cdk-eks-cluster.template.json
iam-role-root-principal-needs-conditions.guard❌ failure

@Abogical Abogical added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jan 19, 2026
@Abogical Abogical had a problem deploying to deployment-integ-test January 19, 2026 23:12 — with GitHub Actions Failure
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 19, 2026 23:12

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@Abogical Abogical changed the title fix(eks-v2-alpha): ensure kubectl provider access entry is depended upon by downstream resources fix(eks-v2-alpha): ensure kubectl provider and handler functions use the same vpc configuration Jan 19, 2026
@pahud pahud mentioned this pull request Jan 20, 2026
Open
@pahud pahud mentioned this pull request Jan 21, 2026
Open
@Abogical Abogical force-pushed the eks-alpha-kubectl-vpc branch from 6617909 to 9081252 Compare January 21, 2026 12:36
@Abogical Abogical had a problem deploying to deployment-integ-test January 21, 2026 12:36 — with GitHub Actions Error
@Abogical Abogical removed the pr/needs-integration-tests-deployment Requires the PR to deploy the integration test snapshots. label Jan 21, 2026
@Abogical Abogical mentioned this pull request Jan 21, 2026
Closed
1 task
@Abogical
Copy link
Member Author

Abogical commented Jan 21, 2026 •
edited
Loading

To fix the merge conflicts, I had to "dry run" generate the snapshots with the merge conflicts fixed.

@Abogical Abogical force-pushed the eks-alpha-kubectl-vpc branch from 8af8c33 to 1dd000f Compare January 21, 2026 13:58
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 21, 2026
@Abogical Abogical force-pushed the eks-alpha-kubectl-vpc branch from 0d58289 to f357237 Compare February 3, 2026 14:06
@Abogical Abogical assigned kumsmrit and unassigned kumsmrit Feb 4, 2026
@alvazjor alvazjor self-assigned this Feb 5, 2026
@mergify
Copy link
Contributor

mergify bot commented Feb 5, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Feb 5, 2026 •
edited
Loading

Merge Queue Status

✅ The pull request has been merged at 8621165

This pull request spent 57 minutes 57 seconds in the queue, including 43 minutes 10 seconds running CI.
The checks were run in-place.

Required conditions to merge

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 5, 2026
@mergify
Copy link
Contributor

mergify bot commented Feb 5, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Feb 5, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4e02f08 into main Feb 5, 2026
20 of 23 checks passed
@mergify mergify bot deleted the eks-alpha-kubectl-vpc branch February 5, 2026 11:39
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alvazjor alvazjor alvazjor approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

@alvazjor alvazjor

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(aws-eks-v2-alpha): kubectl provider function cannot be placed outside of VPC

5 participants

@Abogical @aws-cdk-automation @alvazjor @kumsmrit @msessa