Skip to content

fix(eks-v2-alpha): ensure kubectl provider and handler functions use the same vpc configuration#34878

Closed
msessa wants to merge 3 commits intoaws:mainfrom
msessa:fix/eks-alpha-kubectl-vpc
Closed

fix(eks-v2-alpha): ensure kubectl provider and handler functions use the same vpc configuration#34878
msessa wants to merge 3 commits intoaws:mainfrom
msessa:fix/eks-alpha-kubectl-vpc

Conversation

@msessa
Copy link
Contributor

@msessa msessa commented Jul 2, 2025

Issue # (if applicable)

Closes #34877

Reason for this change

The kubectl Provider function VpcConfig should match the Handler function.

Description of changes

  • Ensured the same vpc construct is passed to both Handler and Provider

Description of how you validated changes

  • Fixed the tests which were hiding the problem

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 2, 2025 06:18
@github-actions github-actions bot added bug This issue is a bug. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jul 2, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Jul 2, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@msessa msessa changed the title fix(aws-eks-v2-alpha): ensure kubectl provider and handler functions use the same vpc configuration fix(eks-v2-alpha): ensure kubectl provider and handler functions use the same vpc configuration Jul 2, 2025
@msessa
Copy link
Contributor Author

msessa commented Jul 2, 2025

Exemption Request: No functional change to express in an integration test

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jul 2, 2025
@msessa msessa force-pushed the fix/eks-alpha-kubectl-vpc branch from ebfe321 to 6edc85b Compare July 2, 2025 07:02
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 2, 2025
@pahud pahud mentioned this pull request Jul 2, 2025
Closed
1 task
@msessa msessa requested a review from aws-cdk-automation July 3, 2025 00:18
@msessa msessa mentioned this pull request Jul 3, 2025
Closed
1 task
@vishaalmehrishi vishaalmehrishi self-assigned this Jul 7, 2025
vishaalmehrishi
vishaalmehrishi approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@vishaalmehrishi vishaalmehrishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you for the fix!

@vishaalmehrishi
Copy link
Contributor

vishaalmehrishi commented Jul 7, 2025

Re integration tests: I think it would be good to update existing tests/add new tests which verify that the provider and handler lambdas are set up using the same VPC configuration.

@msessa msessa force-pushed the fix/eks-alpha-kubectl-vpc branch from db0b136 to 6b84e80 Compare July 16, 2025 12:51
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 16, 2025
@msessa msessa force-pushed the fix/eks-alpha-kubectl-vpc branch from 6b84e80 to 65ea7d8 Compare July 17, 2025 04:07
@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Jul 17, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 65ea7d8
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions github-actions bot mentioned this pull request Aug 1, 2025
Closed
@vishaalmehrishi vishaalmehrishi removed the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jan 13, 2026
@pahud pahud mentioned this pull request Jan 13, 2026
Open
@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Jan 14, 2026

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

  • Resume work on the PR
  • OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
  • OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.

@Abogical Abogical added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jan 14, 2026
@Abogical
Copy link
Member

Abogical commented Jan 14, 2026

Hi @msessa !
The PR is approved, however it can cant be merged the snapshots are out of date and cause merge conflicts. Can you update them?

@aws-cdk-automation aws-cdk-automation dismissed their stale review January 14, 2026 09:54

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@Abogical Abogical mentioned this pull request Jan 19, 2026
Merged
@Abogical
Copy link
Member

Abogical commented Jan 21, 2026

Closing in favor of #36735. This is the same patch with updated snapshots.

@Abogical Abogical closed this Jan 21, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vishaalmehrishi vishaalmehrishi vishaalmehrishi approved these changes

@aws-cdk-automation aws-cdk-automation Awaiting requested review from aws-cdk-automation

Assignees

@vishaalmehrishi vishaalmehrishi

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(aws-eks-v2-alpha): kubectl provider function cannot be placed outside of VPC

4 participants

@msessa @vishaalmehrishi @aws-cdk-automation @Abogical