Redact pre-signed upload URLs in verbose output#19146
Merged
Conversation
zsol
commented
Apr 24, 2026
Comment on lines
+870
to
+872
| if let Some(url) = err.url_mut() { | ||
| DisplaySafeUrl::redact_sensitive_query_parameter_values(url); | ||
| } |
Member
Author
There was a problem hiding this comment.
Not super sure about this, should look into wrapping the error type instead
Member
Author
There was a problem hiding this comment.
I've decided to punt on this for now - it seems safe, but I think a more robust approach would be better (like wrapping reqwest errors in a displaysafe type). Soon.
fac4700 to
1c95afc
Compare
woodruffw
reviewed
Apr 24, 2026
woodruffw
reviewed
Apr 24, 2026
| const SENSITIVE_QUERY_PARAMETERS: &[&str] = &[ | ||
| "X-Amz-Credential", | ||
| "X-Amz-Security-Token", | ||
| "X-Amz-Signature", |
Member
There was a problem hiding this comment.
Q: are there other request signing schemes we'll want to support here eventually? If so we might (eventually) want to have a LazyLock<FxHashSet> or similar, but definitely not needed for now 🙂
1c95afc to
830a963
Compare
woodruffw
approved these changes
Apr 24, 2026
zanieb
added a commit
that referenced
this pull request
Apr 30, 2026
Small follow-up to #19146 which I was looking into independently as a follow-up from the Codex security patch at zaniebot#19 --------- Co-authored-by: zaniebot <zaniebot@accounts.zanie.blue>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This teaches
DisplaySafeUrlabout sensitive query parameters (that are typically used to sign S3 requests) to avoid leaking them in verbose logs.Note: Errors might still contain these in two places:
This PR is part of a stack containing 2 PRs:
main