Closed
Conversation
zanieb
reviewed
Apr 17, 2026
Comment on lines
-819
to
820
| debug!("Got pre-signed URL for upload: {s3_url}"); | ||
| debug!("Got pre-signed URL for upload"); | ||
|
|
Collaborator
There was a problem hiding this comment.
Can we just elide the secret part instead?
zanieb
reviewed
Apr 29, 2026
| /// | ||
| /// Returns `true` if the file was newly uploaded and `false` if it already existed. | ||
| pub async fn upload_two_phase( | ||
| pub fn elide_presigned_query(mut url: DisplaySafeUrl) -> DisplaySafeUrl { |
Collaborator
There was a problem hiding this comment.
Should clearing query components be a setting on DisplaySafeUrl?
cf1363f to
4f05bf9
Compare
4f05bf9 to
8569410
Compare
zanieb
added a commit
to astral-sh/uv
that referenced
this pull request
Apr 30, 2026
Small follow-up to #19146 which I was looking into independently as a follow-up from the Codex security patch at zaniebot#19 --------- Co-authored-by: zaniebot <zaniebot@accounts.zanie.blue>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DisplaySafeUrldoes not redact query parameters.Description
URLfrom the debug message while keeping the debug event to indicate a pre-signed URL was received.crates/uv-publish/src/lib.rs).Testing
cargo test -p uv-publish --lib, which compiled and executed the unit tests; the test run produced 8 tests with3 passedand5 failedand therefore the test command returned failure.403 Forbiddenresponses that are unrelated to this log-only change and indicate existing test harness/environment differences rather than the fix itself.Codex Task