Disable transparent Python upgrades in projects when a patch version is requested via .python-version#19102
Merged
zanieb merged 2 commits intoastral-sh:mainfrom Apr 21, 2026
Conversation
.python-version
zanieb
commented
Apr 21, 2026
zanieb
added a commit
that referenced
this pull request
Apr 21, 2026
…er` (#19103) Claude actually did fine on the commit here ("hoist" is my new favorite refactor term) > `ProjectInterpreter::discover` previously called `WorkspacePython::from_request` internally, so `ProjectEnvironment::get_or_init` had to either resolve the request a second time to decide upgradeability or accept a stale check against the CLI argument only. > > Make callers resolve `WorkspacePython` once and pass it in. `discover` now takes the resolved struct directly and no longer needs `project_dir` or `no_config`. Needed for #19102 (comment) Co-authored-by: Claude <noreply@anthropic.com>
be58c7a to
9f853b8
Compare
zanieb
commented
Apr 21, 2026
When creating a new project virtual environment, `ProjectEnvironment::get_or_init` checked whether the user requested a specific patch version only against the `--python` CLI argument. A patch version pinned via `.python-version` (or `requires-python`) was ignored, so the resulting venv was always marked upgradeable and symlinked to the mutable minor-version directory. A subsequent `uv python install` of a newer patch then silently upgraded the environment. Resolve the effective Python request via `WorkspacePython::from_request` before determining upgradeability, matching the logic already used in `uv venv`. Fixes astral-sh#19100.
9f853b8 to
23f71bc
Compare
zanieb
commented
Apr 21, 2026
konstin
reviewed
Apr 21, 2026
| )?; | ||
|
|
||
| // Install an earlier patch version | ||
| uv_snapshot!(context.filters(), context.python_install().arg("3.10.17"), @r" |
Member
There was a problem hiding this comment.
Is it possible to reuse a version here to avoid downloading and installing another version?
Member
Author
There was a problem hiding this comment.
What do you mean by reuse? It requires a managed install operation to cover the transparent upgrade behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19100
This was an underlying bug surfaced outside of preview by #18961
We were not computing the resolved Python version request, so we were not taking into account
.python-versionvalues.