Hoist WorkspacePython resolution out of ProjectInterpreter::discover#19103
Merged
Hoist WorkspacePython resolution out of ProjectInterpreter::discover#19103
WorkspacePython resolution out of ProjectInterpreter::discover#19103Conversation
`ProjectInterpreter::discover` previously called `WorkspacePython::from_request` internally, so `ProjectEnvironment::get_or_init` had to either resolve the request a second time to decide upgradeability or accept a stale check against the CLI argument only. Make callers resolve `WorkspacePython` once and pass it in. `discover` now takes the resolved struct directly and no longer needs `project_dir` or `no_config`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude actually did fine on the commit here ("hoist" is my new favorite refactor term)
Needed for #19102 (comment)