[`flake8-simplify`] Make the fix for `collapsible-if` (`SIM102`) safe in `preview` by dylwil3 · Pull Request #24371 · astral-sh/ruff

dylwil3 · 2026-04-02T18:19:50Z

As far as I can tell the fix for collapsible-if (SIM102) is safe. We already avoid dropping any comments (the fix is not offered in that case), and are quite careful to avoid false positives (since we allow nothing between the two if headers).

So I propose making this Safe in preview.

astral-sh-bot · 2026-04-02T18:33:54Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+208 -208 violations, +0 -0 fixes in 11 projects; 45 projects unchanged)

aiven/aiven-client (+2 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

- aiven/client/argx.py:112:13: SIM102 Use a single `if` statement instead of nested `if` statements
+ aiven/client/argx.py:112:13: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- aiven/client/cli.py:5000:13: SIM102 Use a single `if` statement instead of nested `if` statements
+ aiven/client/cli.py:5000:13: SIM102 [*] Use a single `if` statement instead of nested `if` statements

apache/airflow (+102 -102 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview --select ALL

- airflow-core/src/airflow/api_fastapi/auth/tokens.py:293:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ airflow-core/src/airflow/api_fastapi/auth/tokens.py:293:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- airflow-core/src/airflow/api_fastapi/common/db/dags.py:64:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ airflow-core/src/airflow/api_fastapi/common/db/dags.py:64:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py:551:5: SIM102 Use a single `if` statement instead of nested `if` statements
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py:551:5: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- airflow-core/src/airflow/api_fastapi/core_api/routes/public/xcom.py:250:5: SIM102 Use a single `if` statement instead of nested `if` statements
+ airflow-core/src/airflow/api_fastapi/core_api/routes/public/xcom.py:250:5: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py:519:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py:519:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- airflow-core/src/airflow/cli/commands/config_command.py:1030:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ airflow-core/src/airflow/cli/commands/config_command.py:1030:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- airflow-core/src/airflow/cli/commands/config_command.py:905:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ airflow-core/src/airflow/cli/commands/config_command.py:905:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- airflow-core/src/airflow/models/backfill.py:240:5: SIM102 Use a single `if` statement instead of nested `if` statements
+ airflow-core/src/airflow/models/backfill.py:240:5: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- airflow-core/src/airflow/models/serialized_dag.py:538:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ airflow-core/src/airflow/models/serialized_dag.py:538:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- airflow-core/src/airflow/providers_manager.py:1098:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ airflow-core/src/airflow/providers_manager.py:1098:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- airflow-core/src/airflow/serialization/definitions/taskgroup.py:253:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ airflow-core/src/airflow/serialization/definitions/taskgroup.py:253:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- airflow-core/src/airflow/serialization/serialized_objects.py:1418:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ airflow-core/src/airflow/serialization/serialized_objects.py:1418:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements
... 180 additional changes omitted for project

apache/superset (+19 -19 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview --select ALL

- docs/scripts/extract_custom_errors.py:191:5: SIM102 Use a single `if` statement instead of nested `if` statements
+ docs/scripts/extract_custom_errors.py:191:5: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- superset/common/query_object.py:484:13: SIM102 Use a single `if` statement instead of nested `if` statements
+ superset/common/query_object.py:484:13: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- superset/daos/base.py:234:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ superset/daos/base.py:234:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- superset/daos/dataset.py:279:13: SIM102 Use a single `if` statement instead of nested `if` statements
+ superset/daos/dataset.py:279:13: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- superset/daos/report.py:170:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ superset/daos/report.py:170:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements
... 28 additional changes omitted for project

binary-husky/gpt_academic (+3 -3 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

- crazy_functions/PDF_Translate_Nougat.py:82:5: SIM102 Use a single `if` statement instead of nested `if` statements
+ crazy_functions/PDF_Translate_Nougat.py:82:5: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- multi_language.py:166:17: SIM102 Use a single `if` statement instead of nested `if` statements
+ multi_language.py:166:17: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- shared_utils/advanced_markdown_format.py:239:13: SIM102 Use a single `if` statement instead of nested `if` statements
+ shared_utils/advanced_markdown_format.py:239:13: SIM102 [*] Use a single `if` statement instead of nested `if` statements

bokeh/bokeh (+13 -13 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview --select ALL

- docs/bokeh/source/conf.py:116:1: SIM102 Use a single `if` statement instead of nested `if` statements
+ docs/bokeh/source/conf.py:116:1: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- src/bokeh/core/property/dataspec.py:333:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ src/bokeh/core/property/dataspec.py:333:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- src/bokeh/core/property/visual.py:159:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ src/bokeh/core/property/visual.py:159:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- src/bokeh/core/validation/check.py:215:5: SIM102 Use a single `if` statement instead of nested `if` statements
+ src/bokeh/core/validation/check.py:215:5: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- src/bokeh/embed/bundle.py:237:13: SIM102 Use a single `if` statement instead of nested `if` statements
+ src/bokeh/embed/bundle.py:237:13: SIM102 [*] Use a single `if` statement instead of nested `if` statements
... 16 additional changes omitted for project

docker/docker-py (+6 -6 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

- docker/api/build.py:128:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ docker/api/build.py:128:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- docker/api/service.py:26:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ docker/api/service.py:26:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- docker/api/service.py:34:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ docker/api/service.py:34:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- docker/api/service.py:93:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ docker/api/service.py:93:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- docker/utils/utils.py:417:5: SIM102 Use a single `if` statement instead of nested `if` statements
+ docker/utils/utils.py:417:5: SIM102 [*] Use a single `if` statement instead of nested `if` statements
... 2 additional changes omitted for project

ing-bank/probatus (+2 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

- probatus/sample_similarity/resemblance_model.py:160:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ probatus/sample_similarity/resemblance_model.py:160:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- probatus/utils/arrayfuncs.py:106:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ probatus/utils/arrayfuncs.py:106:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements

latchbio/latch (+1 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

- src/latch_cli/snakemake/workflow.py:244:5: SIM102 Use a single `if` statement instead of nested `if` statements
+ src/latch_cli/snakemake/workflow.py:244:5: SIM102 [*] Use a single `if` statement instead of nested `if` statements

prefecthq/prefect (+46 -46 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-fix --output-format concise --preview

- src/integrations/prefect-aws/prefect_aws/observers/ecs.py:645:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ src/integrations/prefect-aws/prefect_aws/observers/ecs.py:645:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- src/integrations/prefect-dbt/prefect_dbt/core/_orchestrator.py:659:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ src/integrations/prefect-dbt/prefect_dbt/core/_orchestrator.py:659:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- src/integrations/prefect-docker/prefect_docker/types.py:46:5: SIM102 Use a single `if` statement instead of nested `if` statements
+ src/integrations/prefect-docker/prefect_docker/types.py:46:5: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- src/prefect/_experimental/bundles/__init__.py:206:9: SIM102 Use a single `if` statement instead of nested `if` statements
+ src/prefect/_experimental/bundles/__init__.py:206:9: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- src/prefect/_experimental/bundles/_ignore_filter.py:207:13: SIM102 Use a single `if` statement instead of nested `if` statements
+ src/prefect/_experimental/bundles/_ignore_filter.py:207:13: SIM102 [*] Use a single `if` statement instead of nested `if` statements
- src/prefect/cli/cloud/asset.py:135:5: SIM102 Use a single `if` statement instead of nested `if` statements
... 81 additional changes omitted for project

... Truncated remaining completed project reports due to GitHub comment length restrictions

Changes by rule (1 rules affected)

code	total	+ violation	- violation	+ fix	- fix
SIM102	416	208	208	0	0

* main: Document adding fixes in CONTRIBUTING.md (#24393) Sort formatter diagnostics in snapshots (#24375) [`pyupgrade`] Fix panic caused by handling of octals in `UP012` (#24390) Upgrade to nix v0.31.2 (#24385) Strip form feeds from indent passed to `dedent_to` (#24381) add recent move of the `deferred` submodule to `.git-blame-ignore-revs` (#24379) [ty] Fix extra_items TypedDict tests (#24367) [ty] Use `infer_type_expression` for validating PEP-613 type aliases (#24370) [`flake8-simplify`] Make the fix for `collapsible-if` (`SIM102`) safe in `preview` (#24371) [ty] Validate TypedDict fields when subclassing (#24338) [ty] pass type context to sequence literals in binary operations (#24197) Add release environment to notify-dependents job (#24372) Bump 0.15.9 (#24369) [ty] Move the `deferred` submodule inside `infer/builder` (#24368) [ty] Infer the `extra_items` keyword argument to class-based TypedDicts as an annotation expression (#24362) [ty] Validate type qualifiers in functional TypedDict fields and the `extra_items` keyword to functional TypedDicts (#24360)

@charliermarsh

##### [\`v0.15.10\`](https://github.com/astral-sh/ruff/blob/HEAD/CHANGELOG.md#01510) Released on 2026-04-09. ##### Preview features - \[`flake8-logging`] Allow closures in except handlers (`LOG004`) ([#24464](astral-sh/ruff#24464)) - \[`flake8-self`] Make `SLF` diagnostics robust to non-self-named variables ([#24281](astral-sh/ruff#24281)) - \[`flake8-simplify`] Make the fix for `collapsible-if` safe in `preview` (`SIM102`) ([#24371](astral-sh/ruff#24371)) ##### Bug fixes - Avoid emitting multi-line f-string elements before Python 3.12 ([#24377](astral-sh/ruff#24377)) - Avoid syntax error from `E502` fixes in f-strings and t-strings ([#24410](astral-sh/ruff#24410)) - Strip form feeds from indent passed to `dedent_to` ([#24381](astral-sh/ruff#24381)) - \[`pyupgrade`] Fix panic caused by handling of octals (`UP012`) ([#24390](astral-sh/ruff#24390)) - Reject multi-line f-string elements before Python 3.12 ([#24355](astral-sh/ruff#24355)) ##### Rule changes - \[`ruff`] Treat f-string interpolation as potential side effect (`RUF019`) ([#24426](astral-sh/ruff#24426)) ##### Server - Add support for custom file extensions ([#24463](astral-sh/ruff#24463)) ##### Documentation - Document adding fixes in CONTRIBUTING.md ([#24393](astral-sh/ruff#24393)) - Fix JSON typo in settings example ([#24517](astral-sh/ruff#24517)) ##### Contributors - [@charliermarsh](https://github.com/charliermarsh) - [@dylwil3](https://github.com/dylwil3) - [@silverstein](https://github.com/silverstein) - [@anishgirianish](https://github.com/anishgirianish) - [@shizukushq](https://github.com/shizukushq) - [@zanieb](https://github.com/zanieb) - [@AlexWaygood](https://github.com/AlexWaygood) ##### [\`v0.15.9\`](https://github.com/astral-sh/ruff/blob/HEAD/CHANGELOG.md#0159) Released on 2026-04-02. ##### Preview features - \[`pyflakes`] Flag annotated variable redeclarations as `F811` in preview mode ([#24244](astral-sh/ruff#24244)) - \[`ruff`] Allow dunder-named assignments in non-strict mode for `RUF067` ([#24089](astral-sh/ruff#24089)) ##### Bug fixes - \[`flake8-errmsg`] Avoid shadowing existing `msg` in fix for `EM101` ([#24363](astral-sh/ruff#24363)) - \[`flake8-simplify`] Ignore pre-initialization references in `SIM113` ([#24235](astral-sh/ruff#24235)) - \[`pycodestyle`] Fix `W391` fixes for consecutive empty notebook cells ([#24236](astral-sh/ruff#24236)) - \[`pyupgrade`] Fix `UP008` nested class matching ([#24273](astral-sh/ruff#24273)) - \[`pyupgrade`] Ignore strings with string-only escapes (`UP012`) ([#16058](astral-sh/ruff#16058)) - \[`ruff`] `RUF072`: skip formfeeds on dedent ([#24308](astral-sh/ruff#24308)) - \[`ruff`] Avoid re-using symbol in `RUF024` fix ([#24316](astral-sh/ruff#24316)) - \[`ruff`] Parenthesize expression in `RUF050` fix ([#24234](astral-sh/ruff#24234)) - Disallow starred expressions as values of starred expressions ([#24280](astral-sh/ruff#24280)) ##### Rule changes - \[`flake8-simplify`] Suppress `SIM105` for `except*` before Python 3.12 ([#23869](astral-sh/ruff#23869)) - \[`pyflakes`] Extend `F507` to flag `%`-format strings with zero placeholders ([#24215](astral-sh/ruff#24215)) - \[`pyupgrade`] `UP018` should detect more unnecessarily wrapped literals (UP018) ([#24093](astral-sh/ruff#24093)) - \[`pyupgrade`] Fix `UP008` callable scope handling to support lambdas ([#24274](astral-sh/ruff#24274)) - \[`ruff`] `RUF010`: Mark fix as unsafe when it deletes a comment ([#24270](astral-sh/ruff#24270)) ##### Formatter - Add `nested-string-quote-style` formatting option ([#24312](astral-sh/ruff#24312)) ##### Documentation - \[`flake8-bugbear`] Clarify RUF071 fix safety for non-path string comparisons ([#24149](astral-sh/ruff#24149)) - \[`flake8-type-checking`] Clarify import cycle wording for `TC001`/`TC002`/`TC003` ([#24322](astral-sh/ruff#24322)) ##### Other changes - Avoid rendering fix lines with trailing whitespace after `|` ([#24343](astral-sh/ruff#24343)) ##### Contributors - [@charliermarsh](https://github.com/charliermarsh) - [@MichaReiser](https://github.com/MichaReiser) - [@tranhoangtu-it](https://github.com/tranhoangtu-it) - [@dylwil3](https://github.com/dylwil3) - [@zsol](https://github.com/zsol) - [@renovate](https://github.com/renovate) - [@bitloi](https://github.com/bitloi) - [@danparizher](https://github.com/danparizher) - [@chinar-amrutkar](https://github.com/chinar-amrutkar) - [@second-ed](https://github.com/second-ed) - [@getehen](https://github.com/getehen) - [@Redovo1](https://github.com/Redovo1) - [@matthewlloyd](https://github.com/matthewlloyd) - [@zanieb](https://github.com/zanieb) - [@InSyncWithFoo](https://github.com/InSyncWithFoo) - [@RenzoMXD](https://github.com/RenzoMXD) Renovate-Branch: renovate/2024.6-ruff-0.15.x Change-Id: Id4bd542d4f128b509284d9dcda312f2b39c29964 Priv-Id: 28ebcacdeffa50cec7a52eee59091a75ca5e9539

dylwil3 added 3 commits April 2, 2026 13:05

make fix safe

9233a89

gate behind preview

a2c5c9d

document preview behavior

13f86b3

dylwil3 added fixes Related to suggested fixes for violations preview Related to preview mode features labels Apr 2, 2026

astral-sh-bot Bot assigned ntBre Apr 2, 2026

astral-sh-bot Bot requested a review from ntBre April 2, 2026 18:19

add url to preview.rs

32a4134

dylwil3 removed the request for review from ntBre April 2, 2026 18:30

dylwil3 unassigned ntBre Apr 2, 2026

dylwil3 mentioned this pull request Apr 2, 2026

docs(SIM102): add fix safety section #24350

Closed

3 tasks

dylwil3 merged commit 50ee3c2 into astral-sh:main Apr 2, 2026
43 checks passed

BrewTestBot mentioned this pull request Apr 9, 2026

ruff 0.15.10 Homebrew/homebrew-core#276824

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[`flake8-simplify`] Make the fix for `collapsible-if` (`SIM102`) safe in `preview`#24371

[`flake8-simplify`] Make the fix for `collapsible-if` (`SIM102`) safe in `preview`#24371
dylwil3 merged 4 commits into
astral-sh:mainfrom
dylwil3:collapsible-fix-safety

dylwil3 commented Apr 2, 2026

Uh oh!

astral-sh-bot Bot commented Apr 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

dylwil3 commented Apr 2, 2026

Uh oh!

astral-sh-bot Bot commented Apr 2, 2026

ruff-ecosystem results

Linter (stable)

Linter (preview)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

`ruff-ecosystem` results