Skip to content

Sort formatter diagnostics in snapshots#24375

Merged
charliermarsh merged 1 commit intomainfrom
charlie/det
Apr 3, 2026
Merged

Sort formatter diagnostics in snapshots#24375
charliermarsh merged 1 commit intomainfrom
charlie/det

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

Summary

Right now these tests are dependent on input order, so changes in the underlying hash can lead to churn in the fixtures. See, e.g.: #24355 (comment).

@astral-sh-bot
Copy link
Copy Markdown

astral-sh-bot bot commented Apr 2, 2026

ruff-ecosystem results

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@charliermarsh charliermarsh marked this pull request as ready for review April 2, 2026 20:57
@charliermarsh charliermarsh added internal An internal refactor or improvement testing Related to testing Ruff itself labels Apr 2, 2026
@charliermarsh charliermarsh merged commit 2fb7c8d into main Apr 3, 2026
43 checks passed
@charliermarsh charliermarsh deleted the charlie/det branch April 3, 2026 13:59
carljm added a commit that referenced this pull request Apr 3, 2026
* main:
  Document adding fixes in CONTRIBUTING.md (#24393)
  Sort formatter diagnostics in snapshots (#24375)
  [`pyupgrade`] Fix panic caused by handling of octals in `UP012` (#24390)
  Upgrade to nix v0.31.2 (#24385)
  Strip form feeds from indent passed to `dedent_to` (#24381)
  add recent move of the `deferred` submodule to `.git-blame-ignore-revs` (#24379)
  [ty] Fix extra_items TypedDict tests (#24367)
  [ty] Use `infer_type_expression` for validating PEP-613 type aliases (#24370)
  [`flake8-simplify`] Make the fix for `collapsible-if` (`SIM102`) safe in `preview` (#24371)
  [ty] Validate TypedDict fields when subclassing (#24338)
  [ty] pass type context to sequence literals in binary operations (#24197)
  Add release environment to notify-dependents job (#24372)
  Bump 0.15.9 (#24369)
  [ty] Move the `deferred` submodule inside `infer/builder` (#24368)
  [ty] Infer the `extra_items` keyword argument to class-based TypedDicts as an annotation expression (#24362)
  [ty] Validate type qualifiers in functional TypedDict fields and the `extra_items` keyword to functional TypedDicts (#24360)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement testing Related to testing Ruff itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants