Workaround Even Better TOML crash related to allOf#15992
Merged
MichaReiser merged 1 commit intomainfrom Feb 6, 2025
Merged
Conversation
Contributor
|
charliermarsh
approved these changes
Feb 6, 2025
ntBre
reviewed
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15978
Even Better TOML doesn't support
allOfwell. In fact, it just crashes.This PR works around this limitation by avoid using
allOfin the automaticallyderived schema for the docstring formatting setting.
Alternatives
schemars introduces
allOfwhenver it sees a$refalongside other object propertiesbecause this is no longer valid according to Draft 7. We could replace the
visitor performing the rewrite but I prefer not to because replacing
allOfwithoneOfis only valid for objects that don't have any other
oneOforanyOfschema.Test Plan
Screen.Recording.2025-02-06.at.13.01.50.mov