Skip to content

Even Better TOML crashes on ruff.toml due to allOf usage #15978

@DavisVaughan

Description

@DavisVaughan

Description

Not sure if you all know this yet, but Even Better TOML in VS Code crashes for me on any ruff.toml, it looks like this:

Untitled.mov

I manually bisect-ed my way through your schema file and figured out it has to do with usage of allOf in these two spots:

ruff/ruff.schema.json

Lines 882 to 890 in c816542

"allOf": [
{
"$ref": "#/definitions/LineWidth"
}
]
},
{
"description": "Respect the line length limit setting for the surrounding Python code.",
"allOf": [

It is nothing ruff is doing wrong, and in fact there is a PR on the taplo side that does fix this exact issue (I confirmed by installing the PR rebased on master and trying again). But it is quite old and we probably need to remind them about it. tamasfe/taplo#644

Feel free to close since there is probably nothing actionable on y'alls part, but I didn't see any issues about this and figured you might want to know.

(Side note that taplo / even better toml is in an interesting spot, as it needs a new active maintainer, but is extremely useful for TOML autocompletion and I'd hate to see that extension die)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingconfigurationRelated to settings and configuration

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions