[taplo-common] fix infinite recursion with composed allOfs#644
[taplo-common] fix infinite recursion with composed allOfs#644sunshowers wants to merge 1 commit intotamasfe:masterfrom
Conversation
| .remove("allOf"); | ||
|
|
||
| let mut merged_all_of = Value::Object(serde_json::Map::default()); | ||
|
|
There was a problem hiding this comment.
I noticed below in line 569, and above in line 512/518/525, that depth wasn't getting subtracted by 1. Is this expected? Naively I'd expect depth to be subtracted here.
|
This one would be really nice to merge! Looks to me like it is just fixing a small bug and making the intended behavior actually happen. It did cause parsing of ruff's toml to break (astral-sh/ruff#15978) which they ended up working around but it would be nice to not have to. I did confirm that this PR (rebased on master) does fix the ruff problem |
|
Ah looks like the project is active again -- apologies for pinging you directly @panekj but I'm wondering if this PR can be merged. The bug is pretty clear and it's a hard blocker for nextest's schema. |
|
Closing and re-doing this after rebasing. |
Hi there!
I was trying to write a schema for nextest's configuration, and I ran into a call stack exhaustion issue. It turned out to be because an
allOfwasn't getting removed even though there was an attempt to do so, leading to infinite recursion.I couldn't find any tests for schemas so I added some. Please let me know if I can rearrange this to your liking somehow, thanks!
(And once this is landed a release would be lovely -- this is a hard blocker for nextest's schema at the moment.)