Skip to content

Remove output-format=text setting#12836

Merged
MichaReiser merged 3 commits intoruff-0.7from
remove-output-format-text
Oct 8, 2024
Merged

Remove output-format=text setting#12836
MichaReiser merged 3 commits intoruff-0.7from
remove-output-format-text

Conversation

@MichaReiser
Copy link
Copy Markdown
Member

@MichaReiser MichaReiser commented Aug 12, 2024 •
edited
Loading

Summary

Using output-format=text is a hard error since Ruff 0.5 (#12010).

This PR removes the custom error message.

Test Plan

ruff failed
  Cause: Failed to parse /home/micha/astral/test/pyproject.toml
  Cause: TOML parse error at line 4, column 15
  |
4 | output-format="text"
  |               ^^^^^^
unknown variant `text`, expected one of `concise`, `full`, `json`, `json-lines`, `junit`, `grouped`, `github`, `gitlab`, `pylint`, `rdjson`, `azure`, `sarif`

@MichaReiser MichaReiser added the configuration Related to settings and configuration label Aug 12, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 12, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

AlexWaygood
AlexWaygood reviewed Aug 12, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thoughts as #12833 (review) -- I'd probably keep the nice error message for another minor version personally, but don't have a strong opinion

@MichaReiser MichaReiser added this to the v0.7 milestone Aug 12, 2024
@MichaReiser MichaReiser changed the base branch from ruff-0.6 to main August 12, 2024 14:00
@AlexWaygood AlexWaygood changed the base branch from main to ruff-0.7 October 8, 2024 11:34
AlexWaygood
AlexWaygood approved these changes Oct 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MichaReiser MichaReiser merged commit 2fffb4f into ruff-0.7 Oct 8, 2024
@MichaReiser MichaReiser deleted the remove-output-format-text branch October 8, 2024 11:46
@AlexWaygood AlexWaygood added the internal An internal refactor or improvement label Oct 8, 2024
AlexWaygood pushed a commit that referenced this pull request Oct 17, 2024
@MichaReiser @AlexWaygood
Remove output-format=text setting (#12836)
202c6a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

configuration Related to settings and configuration internal An internal refactor or improvement

Projects

None yet

Milestone

v0.7

Development

Successfully merging this pull request may close these issues.

2 participants

@MichaReiser @AlexWaygood