Remove output format text and use format full by default#12010
Remove output format text and use format full by default#12010MichaReiser merged 3 commits intoruff-0.5from
text and use format full by default#12010Conversation
text and use format full by defualttext and use format full by default
| | | ||
| | |
There was a problem hiding this comment.
This looks like a bug but it isn't. Or, it is a bug in the test rule that always emits an empty range instead of emitting an actual range.
|
|
I'm a little worried about making this change when the full format is half-complete (#7352) |
|
@zanieb what's the part that you're worried about? I think showing the code frame for diagnostics is already an improvement by itself worth shipping and the format name |
|
It just doesn't feel as useful over the concise output without the fixes being shown (seen feedback from one user about this). Oh well though. |
|
I personally find the source text in the rust compiler extremely useful. I don't think I ever look at the line number to get context on where I need to fix something. |
7aa60a4 to
9bb1ccc
Compare
|
I updated the PR to keep the |
9bb1ccc to
b8d1ba6
Compare
Summary
This PR removes support for the output format
textin favor ofconciseand makesfullthe new default (it was already the default for preview mode). TheOutputFormat::Textis still defined in code so that we can error when it's being used.Resolves #7349
Test Plan
I tested that using
--output-formaton the CLI errors:❯ cargo run --bin ruff -- check --output-format text Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.12s Running `target/debug/ruff check --output-format text` ruff failed Cause: `--output-format=text` is deprecated. Use `--output-format=full` or `--output-format=concise` instead. ❯ cargo run --bin ruff -- check --config="output-format='text'" Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.12s Running `target/debug/ruff check '--config=output-format='\''text'\'''` ruff failed Cause: The Setting `output_format=text` has been deprecated. Update your `--config` CLI arguments to use `output-format="concise"` or `output-format="full"` instead.I verified that using
output-format="text"in the settings errorsconcisein the settings or on the CLI works as expectedfullwhen nooutput-formatis specified on the CLI or in the settings.