MWRAPPER-139: Remove trailing whitespace from fields in properties#139
Merged
cstamas merged 1 commit intoapache:masterfrom May 21, 2024
Merged
MWRAPPER-139: Remove trailing whitespace from fields in properties#139cstamas merged 1 commit intoapache:masterfrom
cstamas merged 1 commit intoapache:masterfrom
Conversation
….properties This prevents issues due to confusion between CRLF and LF when running in more exotic locations such as MINGW on Windows but using ./mvnw rather than ./mvnw.cmd. A prime example of where this is an issue would be on windows-latest GitHub Actions runners. Fixes MWRAPPER-139, MWRAPPER-137.
|
Resolve #279 |
1 similar comment
|
Resolve #279 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MWRAPPER-139: Remove trailing whitespace from fields in maven-wrapper.properties
This prevents issues due to confusion between CRLF and LF when running in more exotic locations such as MINGW on Windows but using ./mvnw rather than ./mvnw.cmd. A prime example of where this is an issue would be on windows-latest GitHub Actions runners.
Fixes MWRAPPER-139, MWRAPPER-137 (which I didn't spot for some reason when reviewing the
existing tickets on JIRA... might have been a blip in JIRA that didn't display it?).
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.