Skip to content

[MWRAPPER-139] Shell scripts break on LF in config for Windows #279

@jira-importer

Description

@jira-importer

Ashley Scopes opened MWRAPPER-139 and commented

Today, I updated the Maven Wrapper in a project I have on GitHub by running ./mvnw wrapper:wrapper, and then pushed it to GitHub.

It appears that upon doing this, the bash scripts no longer work due to how newlines are being interpreted in the maven-wrapper.properties file.

+ ./mvnw --version
distributionUrl is not valid, must match *-bin.zip or maven-mvnd-*.zip, but found 'https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.6/apache-maven-3.9.6-bin.zip
'

This appears to just affect when running on GitHub actions with a Windows runner and the bash shell.

I will see if I can find the issue and raise a fix in an MR


Affects: 3.3.1

Issue Links:

  • MWRAPPER-136 maven-wrapper.properties created with Windows line breaks which mvnw can't handle
    ("fixes")
  • MWRAPPER-137 Can't match distributionUrl when using MINGW64
    ("fixes")

Remote Links:

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingpriority:majorMajor loss of function

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions