Revert PR #3194 that handle beforeAll failures to follow proper contributing rules#3211
Revert PR #3194 that handle beforeAll failures to follow proper contributing rules#3211Tibor17 merged 1 commit intoapache:masterfrom
Conversation
|
we can make it simple and just merge #3200 |
|
@slachiewicz Hi Slawomir. I assigned it to both of us. We can start making a review if you like. |
Actually, these are not two PRs nothing but one. The reason is that the tests uncovered that the previous commit was wrong. It would be hard for someone to imaging two commits as one if the history is analyzed, so therefore it should be really one commit. |
|
We cannot rewrite history of master. So we have to live with it. Just KISS rather than adding even more complexity to history by adding even more commits |
apache#3194)" This reverts commit 4a47a1c. Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
1b1f14e to
71c5d64
Compare
|
Pls don't commit anything right now. We will proceed with @Frawless today and finish this issue. |
|
@Tibor17 Please assign appropriate label to PR according to the type of change. |
This reverts commit 4a47a1c (#3194). We agreed that we will revert this change and put it into #3200 as one PR/commit
Following this checklist to help us incorporate your
contribution quickly and easily:
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.