Properly work with test failures caused during beforeAll phase#3194
Merged
elharo merged 1 commit intoapache:masterfrom Oct 8, 2025
Merged
Properly work with test failures caused during beforeAll phase#3194elharo merged 1 commit intoapache:masterfrom
elharo merged 1 commit intoapache:masterfrom
Conversation
Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
d61f99f to
735963d
Compare
elharo
approved these changes
Oct 8, 2025
|
@elharo The PR can't be associated to a milestone, because there are multiple open milestones. Please add the text "branch: master" to the description to the milestone where this PR belongs to. |
Member
|
This need an IT and was expected to get one |
Contributor
|
There was no comment here saying anything like that, or a request for changes. It looked good and important to me, so I merged it. You can still add an integration test if you want one, but my judgment remains that we're better off with this PR than without it. |
Contributor
Author
|
I will open followup PR with IT hopefully today, just doing some last testing of changes I did. |
6 tasks
Frawless
added a commit
to Frawless/maven-surefire
that referenced
this pull request
Oct 29, 2025
apache#3194)" This reverts commit 4a47a1c. Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
6 tasks
Frawless
added a commit
to Frawless/maven-surefire
that referenced
this pull request
Nov 13, 2025
apache#3194)" This reverts commit 4a47a1c. Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
Frawless
added a commit
to Frawless/maven-surefire
that referenced
this pull request
Nov 14, 2025
apache#3194)" This reverts commit 4a47a1c. Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2622
Closes #2950
The PR change the reporter logic to determine if failures in
@BeforeAllphase were resolved during re-runs which means these are just flakes or if the failures are really errors.Following this checklist to help us incorporate your
contribution quickly and easily:
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.