Add IT and deal with corner cases of handling beforeAll failures#3200
Add IT and deal with corner cases of handling beforeAll failures#3200Tibor17 merged 1 commit intoapache:masterfrom
Conversation
|
Including #3194 |
|
@olamy |
|
@olamy I think the NPE in the unit test ForkedBooterTest.testThreadDump should be orthogonal to this change. If it is orthogonal, then the question is why it fails right here. |
For these purposes I need to have an access to the file system of the this run because there are the logs and stacktraces I need for the analysis. Jenkins was good in this, and now I am missing it. |
d2ae5ec to
ffa782c
Compare
| XMLWriter ppw = new PrettyPrintXMLWriter(new PrintWriter(fw), XML_INDENT, XML_NL, UTF_8.name(), null); | ||
|
|
||
| createTestSuiteElement(ppw, testSetReportEntry, testSetStats); // TestSuite | ||
| createTestSuiteElement(ppw, testSetReportEntry, classMethodStatistics); // TestSuite |
There was a problem hiding this comment.
Where this TestSetStats come from? Is it the listener event invoked by the test-provider?
Because, logically this TestSetStats makes sense.
Alright, we can accept this, we should consider this as a workaround because the real fix has to be in the Providers and it is not that easy and definitely it is not one PR.
I want to continue with the Roadmap in 3.0.0 milestones which solves multiple issues, and this one too, but it is so complex change that it requires multiple stable PRs promoted one by one.
ffa782c to
36041de
Compare
Signed-off-by: Jakub Stejskal <xstejs24@gmail.com> # Conflicts: # maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactory.java # maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactoryTest.java
36041de to
bdf9fe5
Compare
|
@Tibor17 Please assign appropriate label to PR according to the type of change. |
This PR solves couple of corner cases that wasn't resolved as part of #3194 and also adds IT to cover it.
Following this checklist to help us incorporate your
contribution quickly and easily:
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.