Skip to content

fix(forms): mark field as dirty when value is changed by a bound control#64483

Closed
leonsenft wants to merge 2 commits intoangular:mainfrom
leonsenft:signal-forms-dirty
Closed

fix(forms): mark field as dirty when value is changed by a bound control#64483
leonsenft wants to merge 2 commits intoangular:mainfrom
leonsenft:signal-forms-dirty

Conversation

@leonsenft
Copy link
Copy Markdown
Contributor

@leonsenft leonsenft commented Oct 16, 2025

Fix #64465.
Fix #63623.

@leonsenft leonsenft added this to the Backlog milestone Oct 16, 2025
@leonsenft leonsenft requested a review from kirjs October 16, 2025 23:24
@leonsenft leonsenft added area: forms target: major This PR is targeted for the next major release forms: signals labels Oct 16, 2025
This was referenced Oct 16, 2025
Closed
Closed
leonsenft added a commit to leonsenft/angular that referenced this pull request Oct 16, 2025
@leonsenft
fix(forms): mark field as dirty when value is changed by `ControlValu…
70d1930 
…eAccessor`

This corresponds with fixes made for native and custom signal form
controls: angular#64483.
kirjs
kirjs reviewed Oct 17, 2025
View reviewed changes
leonsenft added a commit to leonsenft/angular that referenced this pull request Oct 17, 2025
@leonsenft
fix(forms): mark field as dirty when value is changed by `ControlValu…
dc2f89e 
…eAccessor`

This corresponds with fixes made for native and custom signal form
controls: angular#64483.
@leonsenft leonsenft added the action: merge The PR is ready for merge by the caretaker label Oct 17, 2025
thePunderWoman pushed a commit that referenced this pull request Oct 17, 2025
@leonsenft @thePunderWoman
fix(forms): mark field as dirty when value is changed by a bound cont…
3529877 
…rol (#64483)

Fix #64465.
Fix #63623.

PR Close #64483
@thePunderWoman
Copy link
Copy Markdown
Contributor

thePunderWoman commented Oct 17, 2025

This PR was merged into the repository. The changes were merged into the following branches:

@leonsenft leonsenft deleted the signal-forms-dirty branch October 17, 2025 16:08
leonsenft added a commit to leonsenft/angular that referenced this pull request Oct 17, 2025
@leonsenft
fix(forms): mark field as dirty when value is changed by `ControlValu…
d59442a 
…eAccessor`

This corresponds with fixes made for native and custom signal form
controls: angular#64483.
thePunderWoman pushed a commit that referenced this pull request Oct 20, 2025
@leonsenft @thePunderWoman
fix(forms): mark field as dirty when value is changed by `ControlValu…
505bde1 
…eAccessor` (#64471)

This corresponds with fixes made for native and custom signal form
controls: #64483.

PR Close #64471
@JoostK JoostK mentioned this pull request Oct 21, 2025
Closed
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Nov 17, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kirjs kirjs kirjs approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: forms forms: signals target: major This PR is targeted for the next major release

Projects

Experimental Signal Forms
Status: Done

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Signal Forms dirty() state not updating when field values change from initial state signal-forms: FormValueControl is unable to mark field as dirty

3 participants

@leonsenft @thePunderWoman @kirjs