Add test coverage to ensure signal form field states are propagated to controls #63884
Closed
leonsenft wants to merge 4 commits intoangular:mainfrom
Closed
Add test coverage to ensure signal form field states are propagated to controls #63884leonsenft wants to merge 4 commits intoangular:mainfrom
leonsenft wants to merge 4 commits intoangular:mainfrom
Conversation
ec1654f to
5e7b793
Compare
Contributor
Author
mmalerba
approved these changes
Sep 29, 2025
Contributor
|
blocked on landing prerequisite PR first |
c36b62d to
9d8c5c1
Compare
Fix several typos caught by the added test cases: * `disabled` attribute for native controls * `readonly` property for custom controls Note that the `name` test cases have been marked `pending()` due to angular#63882.
Fix a bug where the min property of a form field was not correctly propagated to custom controls. Also ensure that min and max are only bound to native input elements that support them.
…o controls Ensure that minLength and maxLength are only bound to native input elements that support them.
Fix type issues revealed by implementing the expected interface.
9d8c5c1 to
0753bb2
Compare
Contributor
Author
Done! |
kirjs
approved these changes
Oct 8, 2025
Contributor
Author
|
google-internal-tests is passing TGP. Not sure why the check hasn't updated. |
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
leonsenft
added a commit
to leonsenft/angular
that referenced
this pull request
Oct 16, 2025
These were made redundant by angular#63884.
thePunderWoman
pushed a commit
that referenced
this pull request
Oct 17, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding test coverage has caught several typos/bugs. I've also updated the runtime to only propagate properties explicitly supported by the underlying control.