feat(router): add a currentNavigation signal to the Router service.#63011
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
feat(router): add a currentNavigation signal to the Router service.#63011JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
feb070a to
9307c27
Compare
atscott
approved these changes
Aug 5, 2025
32f84e5 to
78f36a9
Compare
atscott
approved these changes
Aug 5, 2025
thePunderWoman
approved these changes
Aug 6, 2025
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
reviewed-for: public-api, size-tracking
Member
|
We should run a TGP for this since it broke some targets last time around. |
ranma42
reviewed
Aug 6, 2025
packages/core/schematics/migrations/router-current-navigation/README.md
Outdated
Show resolved
Hide resolved
This new signal property is convenient to derive a `isNavigating` state. `isNavigating = computed(() => !!this.router.currentNavigation())` DEPRECATED: The Router.getCurrentNavigation method is deprecated. Use the Router.currentNavigation signal instead. fixes angular#62958
78f36a9 to
e650fb4
Compare
Member
Author
atscott
approved these changes
Aug 6, 2025
Contributor
|
This PR was merged into the repository by commit 687c374. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This #62971 re-opened
This new signal property is convenient to derive a
isNavigatingstate.isNavigating = computed(() => !!this.router.currentNavigation())DEPRECATED: The Router.getCurrentNavigation method is deprecated. Use the Router.currentNavigation signal instead.
fixes #62958