feat(router): add a currentNavigation signal to the Router
#62971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2bbc640 to
b53f184
Compare
b53f184 to
3e6e1c1
Compare
a9aca0b to
c1ed455
Compare
currentNavigation signal to the RoutercurrentNavigation signal to the Router
c1ed455 to
884fda4
Compare
884fda4 to
71c76a1
Compare
JeanMeche
commented
Aug 3, 2025
|
|
||
| await runMigration(); | ||
| expect(tree.readContent('/test.ts')).toContain( | ||
| 'const currentNavigation = this.router.currentNavigation();', |
Member
Author
There was a problem hiding this comment.
I've been wondering if the migration should also untrack the signal read.
Contributor
There was a problem hiding this comment.
While that would technically be most equivalent to the current getCurrentNavigation behavior, I think it's probably best to assume it matters that things change and to recompute results when they do.
71c76a1 to
c59b7d4
Compare
This new signal property is convenient to derive a `isNavigating` state. `isNavigating = computed(() => !!this.router.currentNavigation())` DEPRECATED: The Router.getCurrentNavigation method is deprecated. Use the Router.currentNavigation signal instead. fixes angular#62958
c59b7d4 to
ced90b9
Compare
atscott
approved these changes
Aug 4, 2025
atscott
approved these changes
Aug 4, 2025
Contributor
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: public-api, size-tracking
thePunderWoman
approved these changes
Aug 4, 2025
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Member
|
This PR was merged into the repository by commit d00b3fe. The changes were merged into the following branches: main |
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Aug 5, 2025
…` service. (angular#62971)" This reverts commit d00b3fe.
crisbeto
added a commit
that referenced
this pull request
Aug 5, 2025
JeanMeche
added a commit
to JeanMeche/angular
that referenced
this pull request
Aug 5, 2025
…ngular#62971) This new signal property is convenient to derive a `isNavigating` state. `isNavigating = computed(() => !!this.router.currentNavigation())` DEPRECATED: The Router.getCurrentNavigation method is deprecated. Use the Router.currentNavigation signal instead. fixes angular#62958
Member
|
Reopening since we had to roll it back. |
himanshu3174
reviewed
Aug 6, 2025
| @@ -0,0 +1,28 @@ | |||
| ## Remove `Router.getCurrentNavihation` migration | |||
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new signal property is convenient to derive a
isNavigatingstate.isNavigating = computed(() => !!this.router.currentNavigation())DEPRECATED: The
Router.getCurrentNavigationmethod is deprecated. Use theRouter.currentNavigationsignal instead.