Skip to content

fix(http): add missing http options allowed in fetch API#62881

Closed
SkyZeroZx wants to merge 1 commit intoangular:mainfrom
SkyZeroZx:fix-http-options
Closed

fix(http): add missing http options allowed in fetch API#62881
SkyZeroZx wants to merge 1 commit intoangular:mainfrom
SkyZeroZx:fix-http-options

Conversation

@SkyZeroZx
Copy link
Copy Markdown
Contributor

The addBody function was not preserving all fetch API options like integrity and referrer when creating request options for POST/PUT/PATCH requests. This caused these options to be stripped out during request construction.

Add Unit Test avoid similar errors in the future.

Issue : #62864

@pullapprove pullapprove bot requested a review from AndrewKushnir July 29, 2025 18:06
@angular-robot angular-robot bot added the area: common/http Issues related to HTTP and HTTP Client label Jul 29, 2025
@ngbot ngbot bot added this to the Backlog milestone Jul 29, 2025
The addBody function was not preserving all fetch API options like integrity and referrer when creating request options for POST/PUT/PATCH requests. This caused these options to be stripped out during request construction.
@SkyZeroZx
Copy link
Copy Markdown
Contributor Author

@JeanMeche Update the issue about lint, you can give it re run

Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thePunderWoman thePunderWoman removed the request for review from AndrewKushnir July 30, 2025 13:28
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Jul 30, 2025
@JeanMeche JeanMeche added target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release labels Jul 30, 2025
thePunderWoman pushed a commit that referenced this pull request Jul 30, 2025
The addBody function was not preserving all fetch API options like integrity and referrer when creating request options for POST/PUT/PATCH requests. This caused these options to be stripped out during request construction.

PR Close #62881
@thePunderWoman
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 245494a.

The changes were merged into the following branches: main, 20.1.x

thePunderWoman added a commit to thePunderWoman/angular that referenced this pull request Jul 30, 2025
thePunderWoman added a commit that referenced this pull request Jul 30, 2025
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: common/http Issues related to HTTP and HTTP Client target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants