fix(http): add missing http options allowed in fetch API (#62881)

SkyZeroZx · thePunderWoman · commit ab6033979a3b · 2025-07-30T14:07:42.000Z
The addBody function was not preserving all fetch API options like integrity and referrer when creating request options for POST/PUT/PATCH requests. This caused these options to be stripped out during request construction. PR Close #62881
diff --git a/packages/common/http/src/client.ts b/packages/common/http/src/client.ts
@@ -58,12 +58,15 @@ function addBody<T>(
     reportProgress: options.reportProgress,
     responseType: options.responseType,
     withCredentials: options.withCredentials,
+    credentials: options.credentials,
     transferCache: options.transferCache,
     keepalive: options.keepalive,
     priority: options.priority,
     cache: options.cache,
     mode: options.mode,
     redirect: options.redirect,
+    integrity: options.integrity,
+    referrer: options.referrer,
   };
 }
 
diff --git a/packages/common/http/test/client_spec.ts b/packages/common/http/test/client_spec.ts
@@ -148,6 +148,41 @@ describe('HttpClient', () => {
       expect(testReq.request.body).toBe(body);
       testReq.flush('hello world');
     });
+    it('validates all fetch API options are properly handled', (done) => {
+      client
+        .post(
+          '/test',
+          {},
+          {
+            credentials: 'include',
+            cache: 'force-cache',
+            priority: 'high',
+            mode: 'cors',
+            redirect: 'follow',
+            referrer: 'www.example.com',
+            integrity: 'sha256-abc',
+            timeout: 1000,
+            keepalive: true,
+            withCredentials: true,
+          },
+        )
+        .subscribe(() => {
+          done();
+        });
+      const testReq = backend.expectOne('/test');
+      expect(testReq.request.credentials).toBe('include');
+      expect(testReq.request.cache).toBe('force-cache');
+      expect(testReq.request.priority).toBe('high');
+      expect(testReq.request.mode).toBe('cors');
+      expect(testReq.request.redirect).toBe('follow');
+      expect(testReq.request.referrer).toBe('www.example.com');
+      expect(testReq.request.integrity).toBe('sha256-abc');
+      expect(testReq.request.timeout).toBe(1000);
+      expect(testReq.request.keepalive).toBe(true);
+      expect(testReq.request.withCredentials).toBe(true);
+      expect(testReq.request.body).toEqual({});
+      testReq.flush({});
+    });
     it('with a json body of false', (done) => {
       client.post('/test', false, {observe: 'response', responseType: 'text'}).subscribe((res) => {
         expect(res.ok).toBeTruthy();
