fix(core): check ngDevMode for undefined#60565
Closed
BenjaminPabst wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): check ngDevMode for undefined#60565BenjaminPabst wants to merge 1 commit intoangular:mainfrom
BenjaminPabst wants to merge 1 commit intoangular:mainfrom
Conversation
Contributor
|
@BenjaminPabst Looks like this has a lint issue. Can you |
5912735 to
6d075be
Compare
This adds a check to "toSignal" whether ngDevMode is not undefined as this can happen for some MFE applications.
6d075be to
4b561d4
Compare
thePunderWoman
pushed a commit
that referenced
this pull request
Mar 27, 2025
This adds a check to "toSignal" whether ngDevMode is not undefined as this can happen for some MFE applications. PR Close #60565
Contributor
|
This PR was merged into the repository by commit 765ba1e. The changes were merged into the following branches: main, 19.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In some MFE applications, ngDevMode is not defined in some cases (see e.g., ngrx/platform#4703) caused by webpack's tree shaking approx, by not checking if it is defined at all, this breaks.
Issue Number: N/A
What is the new behavior?
ngDevMode is also checked for undefined (as already done in other places in the same file).
Does this PR introduce a breaking change?
Other information