Skip to content

fix(signals): skip assertions when ngDevMode is not defined#4703

Merged
timdeschryver merged 1 commit intomainfrom
fix/signals/undefined-ngDevMode
Feb 14, 2025
Merged

fix(signals): skip assertions when ngDevMode is not defined#4703
timdeschryver merged 1 commit intomainfrom
fix/signals/undefined-ngDevMode

Conversation

@markostanimirovic
Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Error is thrown when the ngDevMode global variable is not defined.

Closes #4699

What is the new behavior?

SignalStore assertions are skipped when the ngDevMode global variable is not defined.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 12, 2025

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit a7570ca
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/67ac7058e9fd9400087ada48

@timdeschryver timdeschryver merged commit 0b43014 into main Feb 14, 2025
9 checks passed
@timdeschryver timdeschryver deleted the fix/signals/undefined-ngDevMode branch February 14, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ngDevMode is undefined in an MFE with external or shared dependencies

3 participants