Skip to content

feat(common): introduce experimental httpResource#59876

Closed
alxhub wants to merge 2 commits intoangular:mainfrom
alxhub:experimental/resource/http
Closed

feat(common): introduce experimental httpResource#59876
alxhub wants to merge 2 commits intoangular:mainfrom
alxhub:experimental/resource/http

Conversation

@alxhub
Copy link
Copy Markdown
Member

@alxhub alxhub commented Feb 7, 2025

httpResource is a new frontend to the HttpClient infrastructure. It declares a dependency on an HTTP endpoint. The request to be made can be reactive, updating in response to signals for the URL, method, or otherwise. The response is returned as an instance of HttpResource, a WritableResource with some additional signals which represent parts of the HTTP response metadata (status, headers, etc).

@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: common Issues related to APIs in the @angular/common package labels Feb 7, 2025
@ngbot ngbot bot added this to the Backlog milestone Feb 7, 2025
Saurav-Sharma22

This comment was marked as outdated.

@alxhub alxhub force-pushed the experimental/resource/http branch from f788be2 to 6d675f9 Compare February 7, 2025 17:58
@JeanMeche
Copy link
Copy Markdown
Member

About the Adev failure, this is again due to #54858 and the workaround is the same as #58367 (commenting ADEV tests).

@alxhub alxhub force-pushed the experimental/resource/http branch 2 times, most recently from 0f8d422 to dfdf2e9 Compare February 10, 2025 17:22
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 10, 2025

Deployed adev-preview for 8aec2df to: https://ng-dev-previews-fw--pr-angular-angular-59876-adev-prev-nq5hq5l9.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@alxhub alxhub force-pushed the experimental/resource/http branch 4 times, most recently from 8d72162 to dc3ca81 Compare February 10, 2025 19:55
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Feb 10, 2025
@alxhub alxhub force-pushed the experimental/resource/http branch 2 times, most recently from 766618b to a32144d Compare February 10, 2025 20:06
@alxhub alxhub added area: common/http Issues related to HTTP and HTTP Client target: minor This PR is targeted for the next minor release and removed area: common Issues related to APIs in the @angular/common package labels Feb 10, 2025
@alxhub alxhub force-pushed the experimental/resource/http branch from a32144d to d2f90cd Compare February 11, 2025 00:34
@angular-robot angular-robot bot added area: common Issues related to APIs in the @angular/common package and removed area: common/http Issues related to HTTP and HTTP Client labels Feb 11, 2025
@alxhub alxhub marked this pull request as ready for review February 11, 2025 00:52
@pullapprove pullapprove bot requested a review from josephperrott February 11, 2025 00:52
Copy link
Copy Markdown
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pullapprove pullapprove bot requested review from atscott and kirjs February 11, 2025 15:03
@alxhub alxhub force-pushed the experimental/resource/http branch from d2f90cd to 55c872a Compare February 11, 2025 17:03
The changes in angular#58288 are responsible for breaking the tests. (see angular#54858).
We'll re-enable them on the next release.
@alxhub alxhub force-pushed the experimental/resource/http branch from 55c872a to dc91c85 Compare February 11, 2025 17:54
@pullapprove pullapprove bot requested a review from kirjs February 12, 2025 15:44
@alxhub alxhub force-pushed the experimental/resource/http branch 2 times, most recently from 2c7bb36 to 885006c Compare February 13, 2025 17:18
`httpResource` is a new frontend to the `HttpClient` infrastructure. It
declares a dependency on an HTTP endpoint. The request to be made can be
reactive, updating in response to signals for the URL, method, or otherwise.
The response is returned as an instance of `HttpResource`, a
`WritableResource` with some additional signals which represent parts of the
HTTP response metadata (status, headers, etc).
@alxhub alxhub force-pushed the experimental/resource/http branch from 885006c to 8aec2df Compare February 13, 2025 20:48
Copy link
Copy Markdown
Contributor

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api

Copy link
Copy Markdown
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api
Reviewed-for: fw-core

@alxhub alxhub added the action: merge The PR is ready for merge by the caretaker label Feb 14, 2025
thePunderWoman pushed a commit that referenced this pull request Feb 14, 2025
`httpResource` is a new frontend to the `HttpClient` infrastructure. It
declares a dependency on an HTTP endpoint. The request to be made can be
reactive, updating in response to signals for the URL, method, or otherwise.
The response is returned as an instance of `HttpResource`, a
`WritableResource` with some additional signals which represent parts of the
HTTP response metadata (status, headers, etc).

PR Close #59876
@thePunderWoman
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 3e39da5.

The changes were merged into the following branches: main

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: build & ci Related the build and CI infrastructure of the project area: common Issues related to APIs in the @angular/common package detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.