refactor(core): remove the standalone feature#58288
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): remove the standalone feature#58288JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
f7e1c14 to
29625a4
Compare
29625a4 to
8964157
Compare
8964157 to
b948c06
Compare
b948c06 to
9094102
Compare
9094102 to
00d8d64
Compare
00d8d64 to
32fd6a2
Compare
32fd6a2 to
8b91714
Compare
Contributor
By removing the standalone feature, we reduce the amount of code generated for components but at the cost of including the `StandaloneService` in the main bundle even if no standalone components are included in it.
8e45f9e to
822bf25
Compare
Member
Author
|
Rebased to resolve the conflicts, It'll need a re-approval @AndrewKushnir |
AndrewKushnir
approved these changes
Oct 24, 2024
Contributor
|
Caretaker note: presubmit status got reset due to a rebase. No extra presubmit is required. |
Member
|
This PR was merged into the repository by commit 5d9cc8f. The changes were merged into the following branches: main, 19.0.x |
alxhub
pushed a commit
that referenced
this pull request
Oct 24, 2024
By removing the standalone feature, we reduce the amount of code generated for components but at the cost of including the `StandaloneService` in the main bundle even if no standalone components are included in it. PR Close #58288
JeanMeche
added a commit
to JeanMeche/angular
that referenced
this pull request
Oct 25, 2024
The changes in angular#58288 are responsible for breaking the tests (see angular#54858). We'll re-enable them on the next release.
devversion
pushed a commit
that referenced
this pull request
Oct 25, 2024
devversion
pushed a commit
that referenced
this pull request
Oct 25, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By removing the standalone feature, we reduce the amount of code generated for components but at the cost of including the
StandaloneServicein the main bundle even if no standalone components are included in it.Had to move some functions due to cyclic imports. Ideally, I would have gone with dropping the
getStandaloneInjectormethod entirely, but we can't access it directly in theComponentFactorybecause of the said cyclic import.