feat(compiler): Add Skip Hydration diagnostic.#59576
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
feat(compiler): Add Skip Hydration diagnostic.#59576JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
|
@JeanMeche the CircleCI rerun you requested failed. See details below: |
The diagnostic was created in angular#49512 but was never added to the list of diagnostic that run. fixes angular#59569
6a5cca9 to
d510256
Compare
kirjs
approved these changes
Jan 17, 2025
Member
Author
|
@kirjs I think we should run a TGP for this first as it introduces a new extended diagnostic that could break existing targets. |
Contributor
|
TESTED=TGP |
Contributor
|
TGP is green. This is safe to merge. |
Contributor
|
This PR was merged into the repository by commit 5b20bab. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diagnostic was created in #49512 but was never added to the list of diagnostic that run.
fixes #59569
Since this PR enables a diagnostic, we'll need a TGP.