feat(compiler-cli): Add an extended diagnostic for ngSkipHydration#49512
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
feat(compiler-cli): Add an extended diagnostic for ngSkipHydration#49512JeanMeche wants to merge 1 commit intoangular:mainfrom
ngSkipHydration#49512JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
978367f to
d6897f9
Compare
nSkipHydrationngSkipHydration
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@JeanMeche huge thanks for the help with this change! 👍
The change looks great, I've just left a few minor comments.
goldens/public-api/compiler-cli/extended_template_diagnostic_name.md
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/typecheck/extended/checks/skip_hydration_binding/index.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/typecheck/extended/checks/skip_hydration_binding/index.ts
Outdated
Show resolved
Hide resolved
d6897f9 to
8d10899
Compare
8d10899 to
baffe31
Compare
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@JeanMeche looks great, just a minor comment related to the error message text.
I also noticed that the commit message refers to the ApplicationRef (likely a commit message that was used in other PR). Could you please update the commit message?
Thank you.
packages/compiler-cli/src/ngtsc/typecheck/extended/checks/skip_hydration_not_static/index.ts
Outdated
Show resolved
Hide resolved
This diagnostic ensures that the special attribute `ngSkipHydration` is not a binding and has no other value than `"true"` or an empty value. Fixes angular#49501
baffe31 to
48272d7
Compare
AndrewKushnir
approved these changes
Mar 22, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@JeanMeche looks great, thanks for the PR 👍
AndrewKushnir
approved these changes
Mar 22, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
Contributor
jessicajaniuk
approved these changes
Mar 22, 2023
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
LGTM!
reviewed-for: public-api
Contributor
|
Caretaker note: presubmit is "green". |
Contributor
|
This PR was merged into the repository by commit 03d1d00. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diagnostic ensures that the special attribute
ngSkipHydrationis not a binding and has no other value than"true"or an empty value.Fixes #49501