Skip to content

Reapply "fix(core): Defer afterRender until after first CD (#58250)…#59551

Closed
mmalerba wants to merge 2 commits intoangular:mainfrom
mmalerba:ar-detached
Closed

Reapply "fix(core): Defer afterRender until after first CD (#58250)…#59551
mmalerba wants to merge 2 commits intoangular:mainfrom
mmalerba:ar-detached

Conversation

@mmalerba
Copy link
Copy Markdown
Contributor

@mmalerba mmalerba commented Jan 16, 2025

For afterRender/afterNextRender calls associated with a particular view, ensure that they are not registered until after the first time the view is rendered.

@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jan 16, 2025
@ngbot ngbot bot added this to the Backlog milestone Jan 16, 2025
@mmalerba mmalerba changed the title Reapply "fix(core): Don't run effects in check no changes pass (#58250)… Reapply "fix(core): Defer afterRender until after first CD (#58250)… Feb 5, 2025
@mmalerba mmalerba marked this pull request as ready for review February 5, 2025 18:34
@mmalerba mmalerba requested a review from alxhub February 5, 2025 18:37
@mmalerba mmalerba added the target: minor This PR is targeted for the next minor release label Feb 5, 2025
@mmalerba
Copy link
Copy Markdown
Contributor Author

mmalerba commented Feb 7, 2025

Caretaker note: please patch cl/716042000 when merging

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Feb 7, 2025
@mmalerba mmalerba removed the request for review from pkozlowski-opensource February 7, 2025 23:11
@atscott
Copy link
Copy Markdown
Contributor

atscott commented Feb 12, 2025

This PR was merged into the repository by commit 6789c7e.

The changes were merged into the following branches: main

@atscott atscott closed this in c87e581 Feb 12, 2025
atscott pushed a commit that referenced this pull request Feb 12, 2025
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants