fix(core): cleanup rxResource abort listener#58306
Closed
arturovt wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): cleanup rxResource abort listener#58306arturovt wants to merge 1 commit intoangular:mainfrom
rxResource abort listener#58306arturovt wants to merge 1 commit intoangular:mainfrom
Conversation
pkozlowski-opensource
approved these changes
Oct 23, 2024
pkozlowski-opensource
requested changes
Oct 23, 2024
961a4d7 to
62e6436
Compare
62e6436 to
9e420c9
Compare
9e420c9 to
5de8be9
Compare
30e8751 to
c679488
Compare
c679488 to
29323a6
Compare
29323a6 to
577e7d8
Compare
577e7d8 to
a9ef582
Compare
a9ef582 to
61ff1f3
Compare
61ff1f3 to
e03ab38
Compare
0153139 to
cb59014
Compare
The observable terminates immediately when `error` is called, and no further emissions or completion notifications occur. Thus, we have to remove the `abort` listener in both the `error` and `complete` notifications.
cb59014 to
5d928b2
Compare
pkozlowski-opensource
approved these changes
May 21, 2025
thePunderWoman
pushed a commit
that referenced
this pull request
May 21, 2025
The observable terminates immediately when `error` is called, and no further emissions or completion notifications occur. Thus, we have to remove the `abort` listener in both the `error` and `complete` notifications. PR Close #58306
thePunderWoman
pushed a commit
that referenced
this pull request
May 21, 2025
The observable terminates immediately when `error` is called, and no further emissions or completion notifications occur. Thus, we have to remove the `abort` listener in both the `error` and `complete` notifications. PR Close #58306
Contributor
|
This PR was merged into the repository by commit 93e8565. The changes were merged into the following branches: main, 19.2.x, 20.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The observable terminates immediately when
erroris called, and no further emissions or completion notifications occur. Thus, we have to remove theabortlistener in both theerrorandcompletenotifications.