fix(core): cleanup rxResource abort listener (#58306)

arturovt · thePunderWoman · commit 93e8565f0ef5 · 2025-05-21T15:17:22.000Z
The observable terminates immediately when `error` is called, and no further emissions or completion notifications occur. Thus, we have to remove the `abort` listener in both the `error` and `complete` notifications. PR Close #58306
diff --git a/packages/common/http/src/resource.ts b/packages/common/http/src/resource.ts
@@ -359,6 +359,7 @@ class HttpResourceImpl<T>
             }
 
             send({error});
+            abortSignal.removeEventListener('abort', onAbort);
           },
           complete: () => {
             if (resolve) {
diff --git a/packages/core/rxjs-interop/src/rx_resource.ts b/packages/core/rxjs-interop/src/rx_resource.ts
@@ -82,7 +82,10 @@ export function rxResource<T, R>(opts: RxResourceOptions<T, R>): ResourceRef<T |
 
       sub = streamFn(params).subscribe({
         next: (value) => send({value}),
-        error: (error) => send({error}),
+        error: (error) => {
+          send({error});
+          params.abortSignal.removeEventListener('abort', onAbort);
+        },
         complete: () => {
           if (resolve) {
             send({

Original file line number	Diff line number	Diff line change
`@@ -359,6 +359,7 @@ class HttpResourceImpl<T>`
`359`	`359`	`}`
`360`	`360`
`361`	`361`	`send({error});`
	`362`	`+ abortSignal.removeEventListener('abort', onAbort);`
`362`	`363`	`},`
`363`	`364`	`complete: () => {`
`364`	`365`	`if (resolve) {`