fix(compiler-cli): extended diagnostics not validating ICUs#57845
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
fix(compiler-cli): extended diagnostics not validating ICUs#57845crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
The visitor that all extended diagnostics are based on hadn't implemented the `visitIcu` method which meant that it wasn't detecting any code inside of them. Fixes angular#57838.
devversion
approved these changes
Sep 17, 2024
Member
Author
|
Passing TGP, once I submit one patch internally. |
Member
|
This PR was merged into the repository by commit f611faa. The changes were merged into the following branches: main, 18.2.x |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Sep 18, 2024
This was referenced Oct 12, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The visitor that all extended diagnostics are based on hadn't implemented the
visitIcumethod which meant that it wasn't detecting any code inside of them.Fixes #57838.