Skip to content

fix(compiler-cli): extended diagnostics not validating ICUs #57845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crisbeto wants to merge 1 commit into from
Closed

fix(compiler-cli): extended diagnostics not validating ICUs #57845

crisbeto wants to merge 1 commit into from

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 17, 2024

The visitor that all extended diagnostics are based on hadn't implemented the visitIcu method which meant that it wasn't detecting any code inside of them.

Fixes #57838.

@crisbeto
fix(compiler-cli): extended diagnostics not validating ICUs
57af37d 
The visitor that all extended diagnostics are based on hadn't implemented the `visitIcu` method which meant that it wasn't detecting any code inside of them.

Fixes angular#57838.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release action: global presubmit The PR is in need of a google3 global presubmit labels Sep 17, 2024
@crisbeto crisbeto requested a review from devversion September 17, 2024 07:47
@crisbeto crisbeto removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 17, 2024
@pkozlowski-opensource pkozlowski-opensource added the area: compiler Issues related to `ngc`, Angular's template compiler label Sep 17, 2024
@ngbot ngbot bot added this to the Backlog milestone Sep 17, 2024
@crisbeto
Copy link
Member Author

crisbeto commented Sep 17, 2024

Passing TGP, once I submit one patch internally.

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: global presubmit The PR is in need of a google3 global presubmit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Sep 17, 2024
@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Sep 18, 2024

This PR was merged into the repository by commit f611faa.

The changes were merged into the following branches: main, 18.2.x

pkozlowski-opensource pushed a commit that referenced this pull request Sep 18, 2024
@crisbeto @pkozlowski-opensource
fix(compiler-cli): extended diagnostics not validating ICUs (#57845)
e685ed8 
The visitor that all extended diagnostics are based on hadn't implemented the `visitIcu` method which meant that it wasn't detecting any code inside of them.

Fixes #57838.

PR Close #57845
@rajmcaitm rajmcaitm mentioned this pull request Sep 20, 2024
Open
@gdemarchi-newf gdemarchi-newf mentioned this pull request Sep 20, 2024
Open
@davidjbradshaw davidjbradshaw mentioned this pull request Oct 3, 2024
Merged
@angular angular deleted a comment from 9764319764319764 Oct 4, 2024
This was referenced Oct 12, 2024
Open
Open
Open
Open
Open
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 4, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

@let is declared but its value is never read, when using @let in i18n ICU expressions

3 participants

@crisbeto @pkozlowski-opensource @devversion