Skip to content

fix(migrations): account for explicit standalone: false in migration#57803

Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:standalone-migration-updates
Closed

fix(migrations): account for explicit standalone: false in migration#57803
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:standalone-migration-updates

Conversation

@crisbeto
Copy link
Copy Markdown
Member

@crisbeto crisbeto commented Sep 13, 2024

Fixes that the standalone migration was duplicating the standalone flag if the declaration was standalone: false.

@crisbeto
fix(migrations): account for explicit standalone: false in migration
ebe1250 
Fixes that the standalone migration was duplicating the `standalone` flag if the declaration was `standalone: false`.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: migrations Issues related to `ng update`/`ng generate` migrations labels Sep 13, 2024
@crisbeto crisbeto requested a review from devversion September 13, 2024 07:59
@ngbot ngbot bot added this to the Backlog milestone Sep 13, 2024
@JeanMeche
Copy link
Copy Markdown
Member

JeanMeche commented Sep 13, 2024

I had this also in #57717

@crisbeto
Copy link
Copy Markdown
Member Author

crisbeto commented Sep 13, 2024

This is for the ng generate schematic, not the one that adds standalone: false.

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 13, 2024
@pkozlowski-opensource
Copy link
Copy Markdown
Member

pkozlowski-opensource commented Sep 13, 2024

This PR was merged into the repository by commit 6144612.

The changes were merged into the following branches: main, 18.2.x

pkozlowski-opensource pushed a commit that referenced this pull request Sep 13, 2024
@crisbeto @pkozlowski-opensource
fix(migrations): account for explicit standalone: false in migration (#…
5c86694 
…57803)

Fixes that the standalone migration was duplicating the `standalone` flag if the declaration was `standalone: false`.

PR Close #57803
@rajmcaitm rajmcaitm mentioned this pull request Sep 20, 2024
Open
@gdemarchi-newf gdemarchi-newf mentioned this pull request Sep 20, 2024
Open
@davidjbradshaw davidjbradshaw mentioned this pull request Oct 3, 2024
Merged
This was referenced Oct 12, 2024
Open
Open
Open
Open
Open
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Oct 14, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @JeanMeche @pkozlowski-opensource @devversion