Skip to content

refactor(core): Improve explicit-standalone-flag migration. #57717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JeanMeche wants to merge 1 commit into from
Closed

refactor(core): Improve explicit-standalone-flag migration. #57717

JeanMeche wants to merge 1 commit into from

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Sep 7, 2024 •
edited
Loading

Keep standalone:true

This commit also adds the support of handling standalone proparties assigned by variables (or via shorthand assignments).

@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Sep 7, 2024
@ngbot ngbot bot added this to the Backlog milestone Sep 7, 2024
@JeanMeche JeanMeche force-pushed the fix/schematic-standalone branch 3 times, most recently from ecd9a5e to a23f69a Compare September 8, 2024 23:04
@JeanMeche JeanMeche marked this pull request as ready for review September 9, 2024 01:28
@pullapprove pullapprove bot requested a review from alxhub September 9, 2024 01:28
AndrewKushnir
AndrewKushnir reviewed Sep 11, 2024
View reviewed changes
@JeanMeche
refactor(migrations): Keep standalone:true
5d80ab3 
This commit also adds the support of handling standalone proparties assigned by variables (or via shorthand assignments).
@JeanMeche JeanMeche force-pushed the fix/schematic-standalone branch from a23f69a to 5d80ab3 Compare September 11, 2024 20:47
@angular-robot angular-robot bot added the area: migrations Issues related to `ng update`/`ng generate` migrations label Sep 11, 2024
@JeanMeche
Copy link
Member Author

JeanMeche commented Sep 11, 2024

For compatibility reasons, the migration will skip removing standalone: true, we'll re-enable it later (before the release of course).

@AndrewKushnir AndrewKushnir added target: major This PR is targeted for the next major release action: presubmit The PR is in need of a google3 presubmit labels Sep 13, 2024
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Sep 13, 2024

Presubmit.

@JeanMeche JeanMeche mentioned this pull request Sep 13, 2024
Closed
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Sep 13, 2024
@AndrewKushnir AndrewKushnir removed the request for review from alxhub September 13, 2024 15:53
@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Sep 16, 2024

This PR was merged into the repository by commit 41c212d.

The changes were merged into the following branches: main

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 17, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

+1 more reviewer

@rubiesonthesky rubiesonthesky rubiesonthesky left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: migrations Issues related to `ng update`/`ng generate` migrations target: major This PR is targeted for the next major release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@JeanMeche @AndrewKushnir @pkozlowski-opensource @rubiesonthesky