Skip to content

[Patch port] fix(compiler-cli): emitting references to ngtypecheck files (#57138) #57202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crisbeto wants to merge 1 commit into from
Closed

[Patch port] fix(compiler-cli): emitting references to ngtypecheck files (#57138) #57202

crisbeto wants to merge 1 commit into from

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 31, 2024

Note: this is a patch port of #57138.

Follow-up to #56961 which doesn't appear to have caught all the cases. This change moves the pre-emit untagging to NgCompiler.prepareEmit which seems to cover a bit more comared to NgtscProgram.emit.

Fixes #57135.

@crisbeto
fix(compiler-cli): emitting references to ngtypecheck files (angular#…
a55347a 
…57138)

Follow-up to angular#56961 which doesn't appear to have caught all the cases. This change moves the pre-emit untagging to `NgCompiler.prepareEmit` which seems to cover a bit more comared to `NgtscProgram.emit`.

Fixes angular#57135.

PR Close angular#57138
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note area: compiler Issues related to `ngc`, Angular's template compiler PullApprove: disable labels Jul 31, 2024
@ngbot ngbot bot modified the milestone: Backlog Jul 31, 2024
@crisbeto
Copy link
Member Author

crisbeto commented Jul 31, 2024 •
edited
Loading

Caretaker note: since this is just cherry-picking #57138, I've skipped PullApprove.

thePunderWoman pushed a commit that referenced this pull request Jul 31, 2024
@crisbeto @thePunderWoman
fix(compiler-cli): emitting references to ngtypecheck files (#57138) (#…
1f9e090 
…57202)

Follow-up to #56961 which doesn't appear to have caught all the cases. This change moves the pre-emit untagging to `NgCompiler.prepareEmit` which seems to cover a bit more comared to `NgtscProgram.emit`.

Fixes #57135.

PR Close #57138

PR Close #57202
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Jul 31, 2024

This PR was merged into the repository by commit 1f9e090.

The changes were merged into the following branches: 18.1.x

@josuedeleonaguilar josuedeleonaguilar mentioned this pull request Aug 2, 2024
Open
@mayankv87 mayankv87 mentioned this pull request Aug 4, 2024
Open
@jammyjoe jammyjoe mentioned this pull request Aug 22, 2024
Open
@fjaguado fjaguado mentioned this pull request Aug 22, 2024
Closed
This was referenced Aug 22, 2024
Closed
Closed
@rishabh114 rishabh114 mentioned this pull request Aug 22, 2024
Open
@tFaster tFaster mentioned this pull request Aug 22, 2024
Open
@kidwen kidwen mentioned this pull request Aug 22, 2024
Merged
@lakshamanr lakshamanr mentioned this pull request Aug 22, 2024
Closed
@ambrose40 ambrose40 mentioned this pull request Aug 22, 2024
Open
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Aug 31, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note PullApprove: disable target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@crisbeto @thePunderWoman