fix(compiler): reduce chance of conflicts between generated factory and local variables #57181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostK
approved these changes
Jul 29, 2024
Contributor
|
This PR was merged into the repository by commit 67e0940. The changes were merged into the following branches: main, 18.1.x |
dylhunn
pushed a commit
that referenced
this pull request
Jul 29, 2024
…nd local variables (#57181) Currently we use some short variable names like `t` and `r` in the generated factory functions. They can conflict with local symbols with the same names, if they're used for DI. These changes add a `ɵ` to the generated variables to reduce the chance of conflicts. Fixes #57168. PR Close #57181
thePunderWoman
added a commit
to thePunderWoman/angular
that referenced
this pull request
Aug 1, 2024
…actory and local variables (angular#57181)" This reverts commit 67e0940.
thePunderWoman
added a commit
that referenced
this pull request
Aug 1, 2024
thePunderWoman
added a commit
that referenced
this pull request
Aug 1, 2024
9d1e3c2 to
97d8924
Compare
…nd local variables Currently we use some short variable names like `t` and `r` in the generated factory functions. They can conflict with local symbols with the same names, if they're used for DI. These changes rename the parameters to reduce the change for conflicts. Fixes angular#57168.
97d8924 to
c9f2863
Compare
Member
Author
|
I've changed the naming scheme so the parameters don't contain any special characters. I've also run a TGP which is passing. |
Contributor
|
This PR was merged into the repository by commit d9d68e7. The changes were merged into the following branches: main, 18.1.x |
thePunderWoman
pushed a commit
that referenced
this pull request
Aug 7, 2024
…nd local variables (#57181) Currently we use some short variable names like `t` and `r` in the generated factory functions. They can conflict with local symbols with the same names, if they're used for DI. These changes rename the parameters to reduce the change for conflicts. Fixes #57168. PR Close #57181
This was referenced Aug 22, 2024
This was referenced Aug 28, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use some short variable names like
tandrin the generated factory functions. They can conflict with local symbols with the same names, if they're used for DI.These changes rename the parameters to reduce the change for conflicts.
Fixes #57168.