Skip to content

Revert "fix(compiler): reduce chance of conflicts between generated f… #57230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thePunderWoman wants to merge 1 commit into from
Closed

Revert "fix(compiler): reduce chance of conflicts between generated f… #57230

thePunderWoman wants to merge 1 commit into from

Conversation

@thePunderWoman
Copy link
Contributor

@thePunderWoman thePunderWoman commented Aug 1, 2024

…actory and local variables (#57181)"

This reverts commit 67e0940.

@pullapprove pullapprove bot requested a review from JoostK August 1, 2024 18:29
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release area: compiler Issues related to `ngc`, Angular's template compiler PullApprove: disable labels Aug 1, 2024
@ngbot ngbot bot added this to the Backlog milestone Aug 1, 2024
@thePunderWoman thePunderWoman added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Aug 1, 2024
@thePunderWoman
Copy link
Contributor Author

thePunderWoman commented Aug 1, 2024

Caretaker note: this is a pure revert and will have its own presubmit. So none needed here.

thePunderWoman added a commit that referenced this pull request Aug 1, 2024
@thePunderWoman
Revert "fix(compiler): reduce chance of conflicts between generated f…
ad29621 
…actory and local variables (#57181)" (#57230)

This reverts commit 67e0940.

PR Close #57230
@thePunderWoman
Copy link
Contributor Author

thePunderWoman commented Aug 1, 2024

This PR was merged into the repository by commit d73a374.

The changes were merged into the following branches: main, 18.1.x

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 1, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 1, 2024
@thePunderWoman thePunderWoman deleted the revert_57181 branch October 22, 2024 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoostK JoostK JoostK approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note PullApprove: disable target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@thePunderWoman @JoostK